Closed Bug 1250981 Opened 4 years ago Closed 4 years ago

crash in -[mozTabsAccessible value]

Categories

(Core :: Disability Access APIs, defect, critical)

Unspecified
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: davidb, Assigned: lsocks)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-bd4d0f6c-2fc1-4d67-a212-ddaeb2160218.
=============================================================

Maybe GetSelectedItem(0) can return null sometimes?

    Accessible* accTab = accWrap->GetSelectedItem(0);
    accTab->GetNativeInterface((void**)&nativeAcc);
Attached patch added null checkSplinter Review
Looks like I accidentally left out the null check when I changed it to add proxies.
Attachment #8723173 - Flags: review?(dbolter)
Comment on attachment 8723173 [details] [diff] [review]
added null check

Review of attachment 8723173 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8723173 - Flags: review?(dbolter) → review+
Assignee: nobody → lorien
https://hg.mozilla.org/mozilla-central/rev/73966acbf7da
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.