Closed
Bug 1251009
Opened 8 years ago
Closed 8 years ago
Remove unused nsICertificateDialogs.notifyCACertExists() method
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
()
Details
Attachments
(1 file)
nsICertificateDialogs.notifyCACertExists() appears to be unused ever since the changes made in Bug 310446. As such, the implementations at https://hg.mozilla.org/mozilla-central/annotate/e22b3043887e/security/manager/pki/nsNSSDialogs.cpp#l162 and https://hg.mozilla.org/mozilla-central/annotate/e2fbc7f6ac3b/mobile/android/components/NSSDialogService.js#l95 are currently dead code. notifyCACertExists() should therefore be removed.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40545/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40545/
Attachment #8731393 -
Flags: review?(mark.finkle)
Attachment #8731393 -
Flags: review?(dkeeler)
Comment on attachment 8731393 [details] MozReview Request: Bug 1251009 - Remove unused nsICertificateDialogs.notifyCACertExists() method. https://reviewboard.mozilla.org/r/40545/#review37109 Removing code that's been sitting unused for almost 10 years = r+
Attachment #8731393 -
Flags: review?(dkeeler) → review+
Comment 3•8 years ago
|
||
Comment on attachment 8731393 [details] MozReview Request: Bug 1251009 - Remove unused nsICertificateDialogs.notifyCACertExists() method. https://reviewboard.mozilla.org/r/40545/#review37823
Attachment #8731393 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Thanks for the reviews! https://treeherder.mozilla.org/#/jobs?repo=try&revision=685aca3b5df1
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1aea33a2d87b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•