Closed Bug 1251009 Opened 4 years ago Closed 4 years ago

Remove unused nsICertificateDialogs.notifyCACertExists() method

Categories

(Core :: Security: PSM, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

References

()

Details

Attachments

(1 file)

nsICertificateDialogs.notifyCACertExists() appears to be unused ever since the changes made in Bug 310446.

As such, the implementations at https://hg.mozilla.org/mozilla-central/annotate/e22b3043887e/security/manager/pki/nsNSSDialogs.cpp#l162 and https://hg.mozilla.org/mozilla-central/annotate/e2fbc7f6ac3b/mobile/android/components/NSSDialogService.js#l95 are currently dead code.

notifyCACertExists() should therefore be removed.
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Comment on attachment 8731393 [details]
MozReview Request: Bug 1251009 - Remove unused nsICertificateDialogs.notifyCACertExists() method.

https://reviewboard.mozilla.org/r/40545/#review37109

Removing code that's been sitting unused for almost 10 years = r+
Attachment #8731393 - Flags: review?(dkeeler) → review+
Comment on attachment 8731393 [details]
MozReview Request: Bug 1251009 - Remove unused nsICertificateDialogs.notifyCACertExists() method.

https://reviewboard.mozilla.org/r/40545/#review37823
Attachment #8731393 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/1aea33a2d87b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Depends on: 306290
You need to log in before you can comment on or make changes to this bug.