1251038 - Make APZ enabled by default in all.js

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now all.js has APZ disabled by default and then we override to true in a bunch of other pref files. We should just make true in all.js and consolidate all the instances.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

I guess this might not be a net win yet, but whatever.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Actually I'm not sure what FxOS TV is doing. APZ is supposedly on there, but it's not a gonk platform so I don't know where it's getting set to true. Maybe it's not actually on.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1251038 - Enable APZ by default in all.js.

The only platform for which this change is *not* a no-op is Mulet. Last time
I checked Mulet worked fine with APZ enabled but there were a few test failures.
Now I don't believe it's running in automation anyhwere so that shouldn't be
an issue. If it is, they can re-disable APZ easily enough if needed.

Review commit: https://reviewboard.mozilla.org/r/62378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62378/

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8767992 [details]
Bug 1251038 - Enable APZ by default in all.js.

https://reviewboard.mozilla.org/r/62378/#review59416

::: browser/app/profile/firefox.js
(Diff revision 1)
>  pref("browser.tabs.crashReporting.sendReport", true);
>  pref("browser.tabs.crashReporting.includeURL", false);
>  pref("browser.tabs.crashReporting.emailMe", false);
>  pref("browser.tabs.crashReporting.email", "");
>  
> -#ifndef MOZ_MULET

Is MOZ_MULET no longer a thing (so that we don't need to add a declaration to disable APZ for it)?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

More or less, yeah. I put a note regarding Mulet in the commit message.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba3d7837019a
Enable APZ by default in all.js. r=botond

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba3d7837019a