nsNSSCertificateDB::AddCertFromBase64 has some NS_ENSURE_SUCCESS uses that cause debug spew when running PSM xpcshell tests (what happens is addCertFromFile in head_psm.js tries to add the certificate in question as if it's DER first, and then falls back to PEM. AddCert (the DER case) base-64 encodes its input and then calls AddCertFromBase64, which fails if the input has already been base-64 encoded. This fires the debug spew.) NS_ENSURE_SUCCESS isn't really appropriate here, since if the input is bad, it's reasonable to expect that decoding it as a certificate will fail. Furthermore, it's not a fatal failure. We should just check for failure and return if so, but without the extra output.
3 years ago
This was fixed as part of the patch for Bug 1296219.
Assignee: nobody → cykesiopka.bmo
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Depends on: 1296219
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.