Closed Bug 1251065 Opened 4 years ago Closed 4 years ago

Add a pref for logging the current/peak texture usage

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: snorp, Unassigned)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

We store and the number of bytes used for textures now, but don't have anywhere to show it other than about:memory. It would be nice to be able to print these values as they change.
Comment on attachment 8723271 [details] [diff] [review]
Add prefs for logging the current and peak texture usage

Review of attachment 8723271 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GfxTexturesReporter.cpp
@@ +59,5 @@
>      if (action == MemoryFreed) {
>          MOZ_RELEASE_ASSERT(amount <= sAmount);
>          sAmount -= amount;
> +
> +        if (Preferences::GetBool("gfx.log-texture-usage.enabled")) {

Can this be called off the main thread ?
Attachment #8723271 - Flags: review?(nical.bugzilla)
Attachment #8723271 - Attachment is obsolete: true
Attachment #8723574 - Flags: review?(nical.bugzilla) → review+
Whiteboard: [gfx-noted]
https://hg.mozilla.org/mozilla-central/rev/d7584b9e0166
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.