1251065 - Add a pref for logging the current/peak texture usage

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We store and the number of bytes used for textures now, but don't have anywhere to show it other than about:memory. It would be nice to be able to print these values as they change.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add prefs for logging the current and peak texture usage

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 8723271 [details] [diff] [review]
Add prefs for logging the current and peak texture usage

Review of attachment 8723271 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GfxTexturesReporter.cpp
@@ +59,5 @@
>      if (action == MemoryFreed) {
>          MOZ_RELEASE_ASSERT(amount <= sAmount);
>          sAmount -= amount;
> +
> +        if (Preferences::GetBool("gfx.log-texture-usage.enabled")) {

Can this be called off the main thread ?

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add prefs for logging the current and peak texture usage

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a820702278bb

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94d1b0a33243

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7584b9e0166

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7584b9e0166