Closed Bug 1251088 Opened 4 years ago Closed 3 years ago

need to update the stored mImageWidth/Height on ImageDocuments when we get the document load event

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed
firefox-esr45 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

Problem discovered in bug 1145903.
Attached patch patchSplinter Review
Attachment #8723319 - Flags: review?(bzbarsky)
UpdateSizeFromLayout flushes, and then accesses member variables of this, so I guess we have a guarantee that the document stays alive somewhere? If not we need to add some safety here.
Comment on attachment 8723319 [details] [diff] [review]
patch

The only current caller of UpdateSizeFromLayout is HandleEvent, and event handling obviously holds strong refs to the node listeners will run on (because otherwise, other listeners firing before this one can kill the object).  So the existing use is ok; this new use will need to take a strong ref to this....

r=me with that.
Attachment #8723319 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/b15d2346d864
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Duplicate of this bug: 1145903
Bug 1145903 hits esr45 on a regular basis still. Is this something that'd be safe to uplift there?
Flags: needinfo?(tnikkel)
Comment on attachment 8723319 [details] [diff] [review]
patch

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: sherriffs asked for this to fix an intermittent
Fix Landed on Version: 48
Risk to taking this patch (and alternatives if risky): should be safe
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Flags: needinfo?(tnikkel)
Attachment #8723319 - Flags: approval-mozilla-esr45?
Comment on attachment 8723319 [details] [diff] [review]
patch

Fix an intermittent, taking it to improve the life of sheriffs
Attachment #8723319 - Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
Should be in 45.4
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.