[FlyWeb] Allow multiple AN entries in mDNS responses when parsing with MulticastDNSFallback.jsm

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: djvj, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The JS implementation of the MDNS discovery code is pretty strict about its parsing, and doesn't handle some slightly-incorrect (yet still present in the wild) methods.

mDNS responses should return a PTR records in the AN section, and any additional records in the AR section.  However, some services respond with dns packets that contain all records in the AN section.

Apple's implementation handles this fine.  We should probably handle it as well.
(Reporter)

Comment 1

2 years ago
Created attachment 8723335 [details] [diff] [review]
handle-multiple-entries-in-answer-section.patch
Attachment #8723335 - Flags: review?(jdarcangelo)
Comment on attachment 8723335 [details] [diff] [review]
handle-multiple-entries-in-answer-section.patch

LGTM
Attachment #8723335 - Flags: review?(jdarcangelo) → review+
(Reporter)

Comment 3

2 years ago
Landed: http://hg.mozilla.org/projects/larch/rev/df6a3c585249
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.