Closed
Bug 1251113
Opened 8 years ago
Closed 8 years ago
PushService fails to cleanup on shutdown due to early state change
Categories
(Core :: DOM: Push Subscriptions, defect)
Core
DOM: Push Subscriptions
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: wchen, Assigned: wchen)
References
Details
(Whiteboard: btpp-fixnow)
Attachments
(1 file)
|
1.23 KB,
patch
|
dragana
:
review+
|
Details | Diff | Splinter Review |
In PushService.uninit we set the uninit state early [1] causing us to fail a check in PushService._stopService [2] that results in failure to clean up resources. This is causing Bug 1243856 to fail because this bug causes us to skip cleanup code that clears timeout tasks. [1] https://dxr.mozilla.org/mozilla-central/rev/d848a5628d801a460a7244cbcdea22d328d8b310/dom/push/PushService.jsm#601 [2] https://dxr.mozilla.org/mozilla-central/rev/d848a5628d801a460a7244cbcdea22d328d8b310/dom/push/PushService.jsm#547
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8723368 -
Flags: review?(dd.mozilla)
|
||
Updated•8 years ago
|
Whiteboard: btpp-fixnow
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8723368 [details] [diff] [review] Change PushService state to PUSH_SERVICE_UNINIT in the state change process queue. Review of attachment 8723368 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #8723368 -
Flags: review?(dd.mozilla) → review+
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9f784f669889
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•