Closed Bug 1251113 Opened 4 years ago Closed 4 years ago

PushService fails to cleanup on shutdown due to early state change

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: wchen, Assigned: wchen)

References

Details

(Whiteboard: btpp-fixnow)

Attachments

(1 file)

In PushService.uninit we set the uninit state early [1] causing us to fail a check in PushService._stopService [2] that results in failure to clean up resources.

This is causing Bug 1243856 to fail because this bug causes us to skip cleanup code that clears timeout tasks.

[1] https://dxr.mozilla.org/mozilla-central/rev/d848a5628d801a460a7244cbcdea22d328d8b310/dom/push/PushService.jsm#601
[2] https://dxr.mozilla.org/mozilla-central/rev/d848a5628d801a460a7244cbcdea22d328d8b310/dom/push/PushService.jsm#547
Blocks: 1243856
Whiteboard: btpp-fixnow
Comment on attachment 8723368 [details] [diff] [review]
Change PushService state to PUSH_SERVICE_UNINIT in the state change process queue.

Review of attachment 8723368 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8723368 - Flags: review?(dd.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/9f784f669889
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.