Closed
Bug 1251177
Opened 8 years ago
Closed 8 years ago
crash in gfxContext::PushGroupAndCopyBackground
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: cyu, Assigned: cyu)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
1.41 KB,
patch
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-e0c92797-a5c6-4969-bef8-3d7a72160223. ============================================================= Stack trace: 0 gfxContext::PushGroupAndCopyBackground(gfxContentType, float, mozilla::gfx::SourceSurface*, mozilla::gfx::Matrix const&) 1 mozilla::layers::BasicLayerManager::PushGroupForLayer(gfxContext*, mozilla::layers::Layer*, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&) Definitely we need to check source is not null before using it in http://hg.mozilla.org/releases/mozilla-beta/annotate/d58154e97af3/gfx/thebes/gfxContext.cpp#l894
Comment hidden (obsolete) |
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eab77ede9032
Assignee | ||
Comment 3•8 years ago
|
||
Assignee: nobody → cyu
Attachment #8723485 -
Flags: review?(jmuizelaar)
Comment 4•8 years ago
|
||
Comment on attachment 8723485 [details] [diff] [review] Fix the crash Review of attachment 8723485 [details] [diff] [review]: ----------------------------------------------------------------- Isn't this tested here: if (pushOpaqueWithCopiedBG && (source = mDT->Snapshot())) { ?
Updated•8 years ago
|
Flags: needinfo?(cyu)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(cyu)
Attachment #8723485 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #4) > Comment on attachment 8723485 [details] [diff] [review] > Fix the crash > > Review of attachment 8723485 [details] [diff] [review]: > ----------------------------------------------------------------- > > Isn't this tested here: > if (pushOpaqueWithCopiedBG && (source = mDT->Snapshot())) { > ? You are right. I was looking at the crash report against an older revision. Sorry that.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•