Closed Bug 1251177 Opened 8 years ago Closed 8 years ago

crash in gfxContext::PushGroupAndCopyBackground

Categories

(Core :: Graphics, defect)

45 Branch
x86
Windows NT
defect
Not set
critical

Tracking

()

RESOLVED INVALID

People

(Reporter: cyu, Assigned: cyu)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-e0c92797-a5c6-4969-bef8-3d7a72160223.
=============================================================
Stack trace:
0 gfxContext::PushGroupAndCopyBackground(gfxContentType, float, mozilla::gfx::SourceSurface*, mozilla::gfx::Matrix const&)
1 mozilla::layers::BasicLayerManager::PushGroupForLayer(gfxContext*, mozilla::layers::Layer*, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&)

Definitely we need to check source is not null before using it in http://hg.mozilla.org/releases/mozilla-beta/annotate/d58154e97af3/gfx/thebes/gfxContext.cpp#l894
Attached patch Fix the crashSplinter Review
Assignee: nobody → cyu
Attachment #8723485 - Flags: review?(jmuizelaar)
Comment on attachment 8723485 [details] [diff] [review]
Fix the crash

Review of attachment 8723485 [details] [diff] [review]:
-----------------------------------------------------------------

Isn't this tested here:
      if (pushOpaqueWithCopiedBG && (source = mDT->Snapshot())) {
?
Flags: needinfo?(cyu)
Flags: needinfo?(cyu)
Attachment #8723485 - Flags: review?(jmuizelaar)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)
> Comment on attachment 8723485 [details] [diff] [review]
> Fix the crash
> 
> Review of attachment 8723485 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Isn't this tested here:
>       if (pushOpaqueWithCopiedBG && (source = mDT->Snapshot())) {
> ?

You are right. I was looking at the crash report against an older revision. Sorry that.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: