Closed
Bug 1251236
Opened 8 years ago
Closed 8 years ago
Please show the diff on the attachment details page when a patch has been reviewed in MozReview
Categories
(bugzilla.mozilla.org Graveyard :: Extensions: MozReview Integration, defect)
bugzilla.mozilla.org Graveyard
Extensions: MozReview Integration
Production
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Sylvestre, Assigned: glob)
Details
Attachments
(1 file)
9.13 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
When trying to review a patch for uplift, if the patch has been reviewed in MozReview, the content is empty: https://bugzilla.mozilla.org/attachment.cgi?id=8720899&action=edit As more and more patches are reviewed using MozReview, we are wasting a lot of time to go back, opening the hg link and coming back to the detail page to approve/reject the upload.
i'm not sure if that's possible, but showing an empty iframe is clearly wrong. what makes this hard is review board set a content-disposition of attachment on its raw diffs. eg. https://reviewboard.mozilla.org/r/35503/diff/raw/ and, of course, what's in the patch doesn't necessarily correlate with what was committed when reviewers say "fix on commit". although that particular issue isn't specific to mozreview and is probably a story for another day. i think the right behaviour here is to probably to provide a link directly to the mozreview diff instead of an empty iframe; perhaps duplicating the mozreview table from the bug.
Assignee: nobody → glob
Summary: Please show the diff when a patch has been reviewed in MozReview → Please show the diff on the attachment details page when a patch has been reviewed in MozReview
Reporter | ||
Comment 2•8 years ago
|
||
A link is good enough! Thanks!
- replaces empty iframe with "Show review on MozReview" link - most of the changes are whitespace - the attachment edit page is still ugly
Attachment #8728268 -
Flags: review?(dylan)
Comment 4•8 years ago
|
||
Comment on attachment 8728268 [details] [diff] [review] 1251236_1.patch Review of attachment 8728268 [details] [diff] [review]: ----------------------------------------------------------------- r=dylan
Attachment #8728268 -
Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 0c94e1d..74c6f99 master -> master
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 6•8 years ago
|
||
This change has been pushed to production. dkl
Updated•6 years ago
|
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•