1251241 - [Static Analysis][Dereference after null check] In function DrawTargetCairo::FillGlyphs

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added if variable |aFont| is nullptr, as it's checked below:

>>  if (!aFont) {
>>    gfxDevCrash(LogReason::InvalidFont) << "Invalid scaled font";
>>  }

it can cause a null pointer dereference:

>>  ScaledFontBase* scaledFont = static_cast<ScaledFontBase*>(aFont);
>>  cairo_set_scaled_font(mContext, scaledFont->GetCairoScaledFont());

As i don't think the execution of the function can continue without sending to cairo the scaled font i thin we should return from the actual function.
Also gfxDevCrash only constructs object Log<LOG_CRITICAL, CriticalLogger> on debug mode at least.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1251241 - return from DrawTargetCairo::FillGlyphs if |aFont| is nullptr. r?roc

Review commit: https://reviewboard.mozilla.org/r/36611/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36611/

Comment 2

[Andi [:andi]]

Comment on attachment 8723563 [details]
MozReview Request: Bug 1251241 - return from  DrawTargetCairo::FillGlyphs if |aFont| is nullptr. r?roc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36611/diff/1-2/

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8723563 [details]
MozReview Request: Bug 1251241 - return from  DrawTargetCairo::FillGlyphs if |aFont| is nullptr. r?roc

https://reviewboard.mozilla.org/r/36611/#review33231

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8723563 [details]
MozReview Request: Bug 1251241 - return from  DrawTargetCairo::FillGlyphs if |aFont| is nullptr. r?roc

https://reviewboard.mozilla.org/r/36611/#review33233

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fc40777e0aa

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8fc40777e0aa