Remove obsolete Yahoo parameter preferences

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Firefox 47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Bug 1247562 hardcoded the values of Yahoo parameters instead of using pref-controlled parameters. Unless I'm missing something, we can now remove these preferences completely.

Note: distribution builds that ship yahoo plugins set these preferences themselves from distribution.ini, so they shouldn't be affected by a change made here.
Assignee

Comment 1

3 years ago
Posted patch PatchSplinter Review
Requesting review from Margaret for the mobile/ parts, and from Mike for the desktop branding files.
Attachment #8723621 - Flags: review?(mconnor)
Attachment #8723621 - Flags: review?(margaret.leibovic)
Assignee

Updated

3 years ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
I'm not sure this is true for Yahoo Japan plugins.

https://bugzilla.mozilla.org/show_bug.cgi?id=1195683

We need to make sure we don't break Yahoo Japan again.
Japanese was hard-coded as well
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/4fa0c95d172b

Note that this change will ride the trains with 46
Comment on attachment 8723621 [details] [diff] [review]
Patch

r=me

Mobile changes look good as well. (I added that param/pref, hardcoding is fine.)
Attachment #8723621 - Flags: review?(mconnor) → review+
Comment on attachment 8723621 [details] [diff] [review]
Patch

Review of attachment 8723621 [details] [diff] [review]:
-----------------------------------------------------------------

mconnor's review is good for mobile here. He has more context about the implications of this change than I do.
Attachment #8723621 - Flags: review?(margaret.leibovic)

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7d72d3447ec4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.