Closed Bug 1251278 Opened 4 years ago Closed 4 years ago

Remove obsolete Yahoo parameter preferences

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Bug 1247562 hardcoded the values of Yahoo parameters instead of using pref-controlled parameters. Unless I'm missing something, we can now remove these preferences completely.

Note: distribution builds that ship yahoo plugins set these preferences themselves from distribution.ini, so they shouldn't be affected by a change made here.
Attached patch PatchSplinter Review
Requesting review from Margaret for the mobile/ parts, and from Mike for the desktop branding files.
Attachment #8723621 - Flags: review?(mconnor)
Attachment #8723621 - Flags: review?(margaret.leibovic)
Assignee: nobody → florian
Status: NEW → ASSIGNED
I'm not sure this is true for Yahoo Japan plugins.

https://bugzilla.mozilla.org/show_bug.cgi?id=1195683

We need to make sure we don't break Yahoo Japan again.
Japanese was hard-coded as well
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/4fa0c95d172b

Note that this change will ride the trains with 46
Comment on attachment 8723621 [details] [diff] [review]
Patch

r=me

Mobile changes look good as well. (I added that param/pref, hardcoding is fine.)
Attachment #8723621 - Flags: review?(mconnor) → review+
Comment on attachment 8723621 [details] [diff] [review]
Patch

Review of attachment 8723621 [details] [diff] [review]:
-----------------------------------------------------------------

mconnor's review is good for mobile here. He has more context about the implications of this change than I do.
Attachment #8723621 - Flags: review?(margaret.leibovic)
https://hg.mozilla.org/mozilla-central/rev/7d72d3447ec4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.