1251278 - Remove obsolete Yahoo parameter preferences

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Florian Quèze [:florian]]

Bug 1247562 hardcoded the values of Yahoo parameters instead of using pref-controlled parameters. Unless I'm missing something, we can now remove these preferences completely.

Note: distribution builds that ship yahoo plugins set these preferences themselves from distribution.ini, so they shouldn't be affected by a change made here.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Requesting review from Margaret for the mobile/ parts, and from Mike for the desktop branding files.

Comment 2

[Mike Kaply [:mkaply]]

I'm not sure this is true for Yahoo Japan plugins.

https://bugzilla.mozilla.org/show_bug.cgi?id=1195683

We need to make sure we don't break Yahoo Japan again.

Comment 3

[Francesco Lodolo [:flod]]

Japanese was hard-coded as well
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/4fa0c95d172b

Note that this change will ride the trains with 46

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 8723621 [details] [diff] [review]
Patch

r=me

Mobile changes look good as well. (I added that param/pref, hardcoding is fine.)

Comment 5

[:Margaret Leibovic]

Comment on attachment 8723621 [details] [diff] [review]
Patch

Review of attachment 8723621 [details] [diff] [review]:
-----------------------------------------------------------------

mconnor's review is good for mobile here. He has more context about the implications of this change than I do.

Comment 6

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/7d72d3447ec40fef848203373a2adbc6cec89b64
Bug 1251278 - Remove obsolete Yahoo parameter preferences, r=mconnor.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d72d3447ec4