Closed
Bug 1251291
Opened 8 years ago
Closed 8 years ago
Tool notices (Take snapshot and Start Recording Performance) should use var(--theme-body-background)
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: ntim, Assigned: vporof)
References
Details
Attachments
(1 file)
2.01 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
They currently use var(--theme-toolbar-background) which does not make sense.
This sounds perf only...? Move again if that's not correct.
Component: Developer Tools: Framework → Developer Tools: Performance Tools (Profiler/Timeline)
Assignee | ||
Comment 3•8 years ago
|
||
I don't think we should fix this here. These buttons simply use the .devtools-toolbarbutton class, no custom background or styling is applied to them.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Reporter | ||
Comment 4•8 years ago
|
||
I'm not talking about the buttons, but the container around them.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Assignee | ||
Comment 5•8 years ago
|
||
Ah. Got it, sorry for closing!
Assignee | ||
Comment 6•8 years ago
|
||
Updated•8 years ago
|
Attachment #8732626 -
Flags: review?(jsantell) → review+
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3810206dc61f099b8eccdd2fa5f4c90d5cd58641 Bug 1251291 - Tool notices (Take snapshot and Start Recording Performance) should use var(--theme-body-background), r=jsantell https://hg.mozilla.org/integration/fx-team/rev/18d1e993e4a117f1debd95a8fac0e1f21a97a37a Bug 1251291 - Tool notices (Take snapshot and Start Recording Performance) should use var(--theme-body-background), r=jsantell
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/18d1e993e4a1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•