Closed Bug 1251291 Opened 4 years ago Closed 4 years ago

Tool notices (Take snapshot and Start Recording Performance) should use var(--theme-body-background)

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: ntim, Assigned: vporof)

References

Details

Attachments

(1 file)

They currently use var(--theme-toolbar-background) which does not make sense.
This sounds perf only...?  Move again if that's not correct.
Component: Developer Tools: Framework → Developer Tools: Performance Tools (Profiler/Timeline)
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Priority: -- → P3
I don't think we should fix this here. These buttons simply use the .devtools-toolbarbutton class, no custom background or styling is applied to them.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
I'm not talking about the buttons, but the container around them.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Ah. Got it, sorry for closing!
Assignee: nobody → vporof
Status: REOPENED → ASSIGNED
Attachment #8732626 - Flags: review?(jsantell)
Attachment #8732626 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/integration/fx-team/rev/3810206dc61f099b8eccdd2fa5f4c90d5cd58641
Bug 1251291 - Tool notices (Take snapshot and Start Recording Performance) should use var(--theme-body-background), r=jsantell

https://hg.mozilla.org/integration/fx-team/rev/18d1e993e4a117f1debd95a8fac0e1f21a97a37a
Bug 1251291 - Tool notices (Take snapshot and Start Recording Performance) should use var(--theme-body-background), r=jsantell
https://hg.mozilla.org/mozilla-central/rev/18d1e993e4a1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Depends on: 1261132
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.