Closed Bug 1251303 Opened 4 years ago Closed 4 years ago

Refactor internal printf implementation a little

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1060419

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Attached patch refactor-jsprfSplinter Review
Here's a patch to clean up a few things that bothered me in jsprf.cpp:

- remove unused members from SprintfState
- use a virtual function rather calling a function pointers
- rename things for general comprehensibility
Attachment #8723647 - Flags: review?(terrence)
Side-note, this printf implementation is cloned multiple times within Gecko.
This makes me think we should just totally rip that stuff out and use standard C methods for this.
Comment on attachment 8723647 [details] [diff] [review]
refactor-jsprf

Review of attachment 8723647 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, please.
Attachment #8723647 - Flags: review?(terrence) → review+
I'm doing this same kind of thing in bug 1060419.
I'm going to close this one as a dup as that one is pretty far along.
I didn't know about this bug at the time or I would have started with it, sorry about that.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1060419
(In reply to Tom Tromey :tromey from comment #6)
No worries, thanks for doing this.
You need to log in before you can comment on or make changes to this bug.