1251303 - Refactor internal printf implementation a little

Status: RESOLVED DUPLICATE of bug 1060419

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: refactor-jsprf

Here's a patch to clean up a few things that bothered me in jsprf.cpp:

- remove unused members from SprintfState
- use a virtual function rather calling a function pointers
- rename things for general comprehensibility

Comment 1

[Nicolas B. Pierron [:nbp]]

Side-note, this printf implementation is cloned multiple times within Gecko.

Comment 2

[Tom S [:evilpie]]

This makes me think we should just totally rip that stuff out and use standard C methods for this.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8723647 [details] [diff] [review]
refactor-jsprf

Review of attachment 8723647 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, please.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94593f55cd01

Comment 5

[Jon Coppeard (:jonco)]

Backed out for causing ASAN failures:

https://hg.mozilla.org/integration/mozilla-inbound/rev/346a7684fde5

Comment 6

[Tom Tromey :tromey]

I'm doing this same kind of thing in bug 1060419.
I'm going to close this one as a dup as that one is pretty far along.
I didn't know about this bug at the time or I would have started with it, sorry about that.

Comment 7

[Jon Coppeard (:jonco)]

(In reply to Tom Tromey :tromey from comment #6)
No worries, thanks for doing this.