Closed Bug 1251373 Opened 4 years ago Closed 4 years ago

Remove moz payment API support

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed
fennec 47+ ---

People

(Reporter: Margaret, Assigned: jmaher)

References

Details

Attachments

(1 file)

This came up in bug 1250650, let's remove this unused code.

This feature was implemented in bug 813756, we can look there to see what code needs to be removed.
let me see how the try run goes, there is a good chance I overlooked a few things- I did this manually, not a 'hg backout...' because starting with that route yielded so many merge conflicts.
Assignee: nobody → jmaher
Flags: needinfo?(jmaher)
it appears that there is one persistent failure which I don't see on the trees:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3935b9de50aa

this is android 4.3 api 15 debug, R17:
REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/dom/canvas/test/reftest/webgl-color-test.html?frame=6&aa&________&premult&_____ | image comparison (==), max difference: 255, number of differing pixels: 1713
REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/dom/canvas/test/reftest/webgl-color-test.html?frame=6&__&preserve&_______&alpha | image comparison (==), max difference: 255, number of differing pixels: 1713
REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/dom/canvas/test/reftest/webgl-color-test.html?frame=6&aa&________&premult&alpha | image comparison (==), max difference: 255, number of differing pixels: 1713
REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/dom/canvas/test/reftest/webgl-color-test.html?frame=6&readback&aa&________&_______&_____ | image comparison (==), max difference: 255, number of differing pixels: 1713
REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/dom/canvas/test/reftest/webgl-color-test.html?frame=6&readback&__&preserve&premult&alpha | image comparison (==), max difference: 255, number of differing pixels: 1713 

Looking at reftest analyzer, we have text in the 'test' image:
Error: Timed out waiting on test completion

Oh, this looks similar to bug 1201075.  We see this in tree randomly (both try and inbound/fx-team).  Now to determine if my changes are causing this or if my try run happens to be the lucky culprit.

:gbrown, as you determined we needed to increase the timeout, is there any signs you see that we should do that again, maybe s/30/40/?

for reference, my changes are here:
https://hg.mozilla.org/try/rev/573715b904bb

as a note, r4 is perma fail on my push, it appears to be so on inbound as well- waiting on more data before filing a bug:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Android%204.3%20API15%2B%20debug%20Reftest%20Reftest%20R%28R4%29&fromchange=10cb85773212&selectedJob=22481259
Flags: needinfo?(jmaher) → needinfo?(gbrown)
Looking at those webgl-color-test failures in isolation, I am tempted to increase the timeout to 40. However, I don't see similar failures on central, and don't recall seeing this type of timeout for a long time now. Also, there are other timeouts (and failures) in your try push (X3, M7, C2, C3), as though something is being slowed down, perhaps intermittently: I think your change has introduced a problem.
Flags: needinfo?(gbrown)
thanks gbrown.  now to figure out why removing the payments code would slow things down.  Maybe something is referencing it and failure is slowing down some operation.
Attachment #8723753 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8723753 [details]
MozReview Request: Bug 1251373 - Remove moz payment API support. r?margaret

https://reviewboard.mozilla.org/r/36705/#review33517

I looked through the tree to see if there's anything else you missed, but I didn't spot anything. Thanks for writing the patch!
https://hg.mozilla.org/mozilla-central/rev/a83ac48ef073
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Ride the trains.
tracking-fennec: ? → 47+
You need to log in before you can comment on or make changes to this bug.