fix some units issues in FrameAnimator

RESOLVED FIXED in Firefox 47

Status

()

Core
ImageLib
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
This came out of the investigation in bug 926048.
(Assignee)

Comment 2

2 years ago
Created attachment 8723777 [details] [diff] [review]
Part 1. Fix unsigned/sign mismatch from return value of GetSingleLoopTime
Attachment #8723777 - Flags: review?(edwin)
(Assignee)

Comment 3

2 years ago
Created attachment 8723779 [details] [diff] [review]
Part 2. Use 64 bit ints for the delay because it could be that big in practice.
Attachment #8723779 - Flags: review?(edwin)
Comment on attachment 8723779 [details] [diff] [review]
Part 2. Use 64 bit ints for the delay because it could be that big in practice.

Review of attachment 8723779 [details] [diff] [review]:
-----------------------------------------------------------------

Heh. Shall we get QA to verify this one? ;)
Attachment #8723779 - Flags: review?(edwin) → review+

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5be4e5b20d33
https://hg.mozilla.org/mozilla-central/rev/52ad95a28384
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.