Establish a shared file for storing static build related data

RESOLVED INCOMPLETE

Status

RESOLVED INCOMPLETE
3 years ago
9 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Patch forthcoming.
(Assignee)

Comment 1

3 years ago
Created attachment 8723783 [details]
MozReview Request: Bug 1251411 - Support defining static build data; r?glandium

There are various static data structures that are shared between
multiple consumers. The build system, mach, etc. Currently, there is
a lot of duplication of this code because there isn't an obvious
location for this shared data.

This commit attempts to change that.

We introduce build/data.py as a standalone Python file that will hold
static data. We import this module in the ConfigEnvironment class and
expose the DATA module attribute (which is a dict) as .data in the
ConfigEnvironment. Consumers will be added in the near future.

We should arguably be putting this data in moz.build files or configure.
At this junction, I'm not ready to commit to either. I'm worried that
we'll end up stuffing lots of data in the root moz.build file. And
given the volatility of configure at the moment, I'd rather wait until
configure.py is running before we consider that. We're talking about
static data, so porting it in the future shouldn't be too difficult.

Review commit: https://reviewboard.mozilla.org/r/36717/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36717/
Attachment #8723783 - Flags: review?(mh+mozilla)
Comment on attachment 8723783 [details]
MozReview Request: Bug 1251411 - Support defining static build data; r?glandium

https://reviewboard.mozilla.org/r/36717/#review33329

I cannot tell whether I want this landed or not without having a clear example of what you expect to end up in this file.
Attachment #8723783 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

2 years ago
I'm not actively working on this. And I don't see a major reason to keep the bug open.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.