1251492 - [DevTools][Memory] menuitem does not work while the Dominators is displayed

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P1)

Description

[magicp]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160225030209

Steps to reproduce:

1. Start Nightly (2016-02-25)
2. Open DevTools > Memory
3. Switch to Dominators view
4. Run Take snapshot
5. Select any menuitem in menubar and context menus


Actual results:

menuitem does not work while the Dominators is displayed.


Expected results:

menuitem works even while the Dominators is displayed.

Comment 1

[magicp]

Regression range
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=730d0b594e31e550cbf538547eb38de4b2591e6a&tochange=dca97b7dfd1f46bacc098f21315640231f93ef68

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Thanks for the report and regression range, magicp.

I don't understand what you mean by:

> 5. Select any menuitem in menubar and context menus

Which menuitem, menubar, and context menus? The dominator tree view doesn't have any of those. I tried reproducing with context menus on the page and was unable to reproduce.

Comment 3

[magicp]

Attachment: 20160227075547.mp4

(In reply to Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] from comment #2)

> Which menuitem, menubar, and context menus? The dominator tree view doesn't
> have any of those. I tried reproducing with context menus on the page and
> was unable to reproduce.

All of menuitems are no response.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Ah, thanks I understand now!

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Don't prevent default behavior of unrelated mouse events in HSplitBox

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6642e1c5c05

Comment 7

[Lin Clark [:linclark]]

Comment on attachment 8724277 [details] [diff] [review]
Don't prevent default behavior of unrelated mouse events in HSplitBox

Review of attachment 8724277 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like this is failing a relevant test

>  211 INFO TEST-UNEXPECTED-FAIL | devtools/client/shared/components/test/mochitest/test_HSplitBox_01.html | Should get 1 resize - got +0, expected 1

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Don't prevent default behavior of unrelated mouse events in HSplitBox

Turns out we were simulating the wrong mouse button in the test, hence the try failures >.<

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=412994a12cf7

Comment 10

[Lin Clark [:linclark]]

Comment on attachment 8725793 [details] [diff] [review]
Don't prevent default behavior of unrelated mouse events in HSplitBox

Review of attachment 8725793 [details] [diff] [review]:
-----------------------------------------------------------------

In case anyone else needs the STR, there was a small clarification that I needed: 

In Step #5, the first right click (to bring up the contextual menu) works. Where you see the bug is when you try to click on anything inside of that contextual menu. The OP showed this in the video.

This patch does what it says on the tin, so r+.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/579da5ef8ccf

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/579da5ef8ccf

Comment 13

[Md. Rahimul Islam]

I have successfully reproduce this bug on firefox nightly 47.0a1 (2016-02-25)
with windows 7 (32 bit)
Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0

I found this fix on latest aurora 47.0a2 (2016-04-20)

Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID : 20160420004046

[bugday-20160420]