Closed Bug 1251511 Opened 4 years ago Closed 4 years ago

update verify override some variables

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(1 file)

See https://tools.taskcluster.net/task-inspector/#rBJlzZ-ZSuKgmQGD4bS89g/

Looks like the script expects it coming from command line (buildbot's ScriptFactory) as 5th argument, but we pass only 4. I actually thought that we are going to pass those via properties.
http://archive.mozilla.org/pub/firefox/tinderbox-builds/date-win64/release-date_win64_update_verify_date_6-bm72-build1-build8.txt.gz

+ '[' -z 1 ']'
++ python /c/builds/moz2_slave/rel-date_w64_u_v_date_6-000000/scripts/scripts/release/updates/../../../buildfarm/utils/jsontool.py -k properties.slavebuilddir /c/builds/moz2_slave/rel-date_w64_u_v_date_6-000000/buildprops.json
Traceback (most recent call last):
  File "c:/builds/moz2_slave/rel-date_w64_u_v_date_6-000000/scripts/scripts/release/updates/../../../buildfarm/utils/jsontool.py", line 25, in <module>
    v = v[k]
KeyError: 'slavebuilddir'
+ SLAVEBUILDDIR=
program finished with exit code 1
Summary: update verify doesn't pass --release-channel → update verify override some variables
Attached patch props.diffSplinter Review
It turns out that JSONTOOL exits with code zero if prop file is not passed. It shouldn't be used in TC.
Attachment #8723960 - Flags: review?(bugspam.Callek)
Assignee: nobody → rail
Comment on attachment 8723960 [details] [diff] [review]
props.diff

Review of attachment 8723960 [details] [diff] [review]:
-----------------------------------------------------------------

I thought I tested that! But o well, here we go - thanks
Attachment #8723960 - Flags: review?(bugspam.Callek) → review+
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.