1251556 - The un-focused app will be deleted in specific steps.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[[e-mail]]

[Description]
The un-focused app will be deleted in specific steps.

[Testing Steps]
1. Launch Apps .
2. Move cursor down to any app.
3. Move cursor up to the top three icon. 
4. Press Option button.
5. Select "Remove".
6. Show "%AppName% and all of its data will be deleted" message.
7. Select "Delete" button.
8. The un-focused app will be deleted.


[Expected result]
6. It should NOT show "%AppName% and all of its data will be deleted" message
8. The un-focused app should NOT be deleted.

[Actual result]
6. Show "%AppName% and all of its data will be deleted" message.
8. The un-focused app will be deleted.
Please refer to: https://youtu.be/Y-vlgHr14dg


[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/1ad93502b639e5c335c15c97882a4c516b2ffa23
gecko:
https://hg.mozilla.org/mozilla-central/rev/c1e0d1890cfee9d86c8d566b0490053f21e0afc6

Comment 1

[Mike Lien[:mlien]]

please help to verify is v2.5 has this problem or not, if yes then nominate it as blocker

Comment 2

[cindylee]

This issue is also observed on v2.5.
[Build Info]
gaia:
https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/38e6a8bdf412a947418ffffc54c4821fe6103f9f
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3

Comment 3

[cindylee]

[Blocking Requested - why for this release]:

Comment 4

[Evelyn Hung]

Rex, I think something is wrong in spatial navigation state. A possible workaround is prevent option menu from the top three Ad icons. Please take a look. Thanks.

@Mike, does this happen on real TV?

Comment 5

[Mike Lien[:mlien]]

Real TV's(Singray) ad icons don't support option key

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Yeah, it's because we didn't decide the behavior of right-click on banners since last version. Current implementation only look for the last focused app/bookmark icon.
I can prevent ad icons from showing option menu.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:1251556 > mozilla-b2g:master

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8725630 [details] [review]
[gaia] rexboy7:1251556 > mozilla-b2g:master

Luke can you take a look for this simple patch?

Comment 9

[Evelyn Hung]

per comment 5, this is not a 2.5 blocker.

Rex, thanks for fixing this. Please land to master only.

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/mozilla-b2g/gaia/commit/74808d450c109ffa421388fc9986c672ebd9bc76

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

sorry, should be this one:

https://github.com/mozilla-b2g/gaia/commit/fecbe1effe8abfedebe5f26319f4ecb9a33dbe43