1251569 - It's not possible to hide "Blocked popup" menu by clicking "Blocked popup" button in urlbar

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 47, 32bit, ID 20160224030246
STR:
1. Open attachment 8666006 [details] (from bug 1208489)
2. Click "Blocked popup" button in urlbar  ["Blocked popup" menu will appear]
3. Click "Blocked popup" button in urlbar

AR:  After Step 3 "Blocked popup" menu blinks (disappears and reappears)
ER:  After Step 3 "Blocked popup" menu should hide.

Comment 1

[arni2033]

This is regression between Firefox 36 and Firefox 38

Comment 2

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Arni,

I have tested this issue on latest Firefox (44.0.2) release, latest Nightly (47.0a1) release, and I have managed to reproduce it. I have also tested on Ubuntu and MAC OS, but it's only reproducible on Windows 7, 8.1, 10.

Firefox: 47.0a1, Build ID: 20160228030239
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Firefox: 44.0.2, Build ID: 20160210153822
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0

I have performed a regression, and I have obtained this pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bb8d6034f5f2&tochange=f5947d58ab02 
Last good revision: bb8d6034f5f2 (2015-01-11)
First bad revision: f5947d58ab02 (2015-01-12)

Considering this I will assign a component for this issue.

Thanks,
Cosmin.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Platform triage meeting decision: This is a minor polish issue and an old regression. We do not feel the need to track this for for Fx47.

Comment 4

[Justin Dolske [:Dolske]]

(Also, I suspect this is a front-end bug, not a widget bug.)

Would expect this to work like other navbar/urlbar buttons that show a panel -- clicking the triggering button while the panel is open should just hide it, not redisplay the menu.

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

As we're now into RC builds, this is wontfix for 47.

Comment 6

[arni2033]

>>>   My Info:   Win7_64, Nightly 52, 32bit, mozilla-central, 74aff44c528a (bug 1148716 comment 12)
This should be the same as bug 1148716. So I guess bug 1148716 wasn't fixed "properly" (didn't really fixed issue introduced in bug 1089005), and instead used a work around. Not 100% sure.

Comment 7

[arni2033]

Forget to mention that this is reproducible with the fix from bug 1148716.
Also, sorry, I missed that component was changed intentionally. I just copied it from bug 1148716.
I'll leave "component" alone for now.

Comment 8

[Marco Bonardo [:mak]]

(In reply to arni2033 from comment #6)
> This should be the same as bug 1148716.

The regressing bug is the same as well as the reason. It's also the same as bug 990846, that likely doesn't affect us anymore cause the go button is no more an urlbar field icon. The reason for the bug is expressed in https://bugzilla.mozilla.org/show_bug.cgi?id=990846#c2

Bug 990846 was marked as difficult to fix (13P), and it may likely regress the fix that caused these regressions. In more than 1 year the underlying widget problem has not been fixed, I'm not really positive about seeing a fix soon.
Since bug 990846 doesn't affect us anymore, atm this is the only remaining regression, and I REALLY hope we are not going to add further icon-buttons to the urlbar field, but rather provide customizeable buttons for those.

This can be workarounded the same way as bug 1148716, and I can attach a patch for that, then it's not my call whether we want to wait (how long?) for a scarier widget fix, or just fix this remaining annoyance. We could file a separate bug to track a proper fix, or reuse Bug 990846 for that.

I'll leave this decision to Dolske, as part of the QX effort.

Comment 9

[Marco Bonardo [:mak]]

Attachment: Bug 1251569 - It's not possible to hide the Blocked Popup menu by clicking its anchor button in urlbar.

Review commit: https://reviewboard.mozilla.org/r/81652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81652/

Comment 10

[arni2033]

(In reply to Marco Bonardo [::mak] from comment #8)
> Since bug 990846 doesn't affect us anymore, atm this is the only remaining regression,
> and I REALLY hope _WE_ are not going to add further icon-buttons to the urlbar field
What about buttons added by extensions? A new bug for each case?

Comment 11

[Marco Bonardo [:mak]]

(In reply to arni2033 from comment #10)
> What about buttons added by extensions? A new bug for each case?

Doesn't look like it's a big deal, since it's almost 2 years this is broken and I honestly didn't see so many complains. I personally think add-ons should not add icons here, as well as we should not.
Unless someone has a better fix at hand, I don't see an alternative solution proposed.

Comment 12

[Justin Dolske [:Dolske]]

Comment on attachment 8795682 [details]
Bug 1251569 - It's not possible to hide the Blocked Popup menu by clicking its anchor button in urlbar.

https://reviewboard.mozilla.org/r/81652/#review85930

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

Marco, should this be landed?

Comment 14

[Marco Bonardo [:mak]]

Ah yes, I didn't see the r+ in the middle of the hundreds bugmails, and since I didn't assign this to me, it slipped through the cracks. Thank you.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19b283720e07
It's not possible to hide the Blocked Popup menu by clicking its anchor button in urlbar. r=Dolske

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/19b283720e07

Comment 17

[Gerry Chang [:gchang]]

Hi ::mak,
Since this bug is a regression and also affects 51, do you consider to uplift this for 51?

Comment 18

[Marco Bonardo [:mak]]

I don't think it's worth it. while the risk is very low, this is just an annoyance, it exists from 2 years, and I don't think 6 weeks will make a real difference for users. Bug 1148716 has not been uplifted as well.