1251592 - Add Empik.com searchplugin

Status: RESOLVED INCOMPLETE

(Mozilla Localizations :: pl / Polish, defect)

Description

[Stefan Plewako [:stef]]

Attachment: patch

In bug 1251445 we removed Merlin.pl and after discussion on community-poland mailing list we would like to add Empik in its place.

Empik is probably most recognizable and quite popular brand in its area in Poland (they are also present on Ukraine), empik.com seems to be similar online store to Merlin but the chain has also many physical locations.

Empik.com with Allegro.pl (online auctions) and Ceneo.pl (price comparison, not added yet) could probably fulfill most popular e-commerce related search tasks for Firefox users in Poland.

Patch based on http://www.empik.com/b/default/xml/opensearch.xml

Comment 1

[Francesco Lodolo [:flod]]

Comment on attachment 8724038 [details] [diff] [review]
patch

Review of attachment 8724038 [details] [diff] [review]:
-----------------------------------------------------------------

The image includes a 24px that we don't need.

Are you already in touch with them? Do you have the information needed to fill the document as explained in bug 1251445?
https://bugzilla.mozilla.org/attachment.cgi?id=8723964

Once the document is ready, we need to ask feedback from Joanne and then proceed with the inclusion.

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> Once the document is ready, we need to ask feedback from Joanne and then
> proceed with the inclusion.

To clarify: ready I mean filled with all the information, before sending it to the provider since it has Joanne's name in it (the process is quite new and we might need to polish some steps).

Comment 3

[Stefan Plewako [:stef]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> Are you already in touch with them? Do you have the information needed to
> fill the document as explained in bug 1251445?

No I'm not and I don't.

I understand that this will be needed before patch lands but does this block approval to add new searchplugin and feedback from the business department?

Wouldn't Mozilla want to contact Empik directly?

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Stefan Plewako [:stef] from comment #3)
> I understand that this will be needed before patch lands but does this block
> approval to add new searchplugin and feedback from the business department?

I prefer not to have a patch reviewed since it cannot land until there is approval from BD that everything looks good. 
r+ means it's technically good and it can land.

> Wouldn't Mozilla want to contact Empik directly?

Normally it's the l10n team requesting the change who gets in touch with them. That also avoid any possible issue with language barrier.

Comment 5

[Stefan Plewako [:stef]]

(In reply to Francesco Lodolo [:flod] from comment #4)
> (In reply to Stefan Plewako [:stef] from comment #3)
> > I understand that this will be needed before patch lands but does this block
> > approval to add new searchplugin and feedback from the business department?
> 
> I prefer not to have a patch reviewed since it cannot land until there is
> approval from BD that everything looks good. 
> r+ means it's technically good and it can land.

Let me rephrase, if some Mozilla department is going to block this plugin addition then I wouldn't like to waste time  contacting searchplugin company to satisfy Mozilla corporate needs in order to only see addition rejected.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Stefan Plewako [:stef] from comment #5)
> Let me rephrase, if some Mozilla department is going to block this plugin
> addition then I wouldn't like to waste time  contacting searchplugin company
> to satisfy Mozilla corporate needs in order to only see addition rejected.

Mozilla needs an authorization to add a searchplugin. It's always been like this, the only difference is that now we have a fac-simile to use, and that we need to keep BD in the loop.

The only thing you need to get this request evaluated from BD is the name of the searchprovider, the address, and the name of a person that will sign the authorization. And you can get that in the first email you send to ask them if they're interested.

I don't own the final approval, and I can't tell you if there's a chance for this request to be rejected.

Comment 7

[Francesco Lodolo [:flod]]

Marking this as INCOMPLETE. If there's interest in adding a new searchplugin, feel free to reopen. The procedure to get legal approval is now clear (see for example bug 1313611).