Closed Bug 1251629 Opened 4 years ago Closed 4 years ago

remove unused reference to PREDICTOR_TESTS in netwerk/base/moz.build

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jmaher, Unassigned)

Details

Attachments

(1 file)

this was found while auditing the ENABLE_TESTS flag.
Attachment #8724109 - Flags: review?(hurley)
I haven't done a try run, if you have something you would like me to verify, please let me know- otherwise as we have determined this is unused and we are just removing it, a try run seems overkill.
Attachment #8724109 - Flags: review?(hurley) → review+
Comment on attachment 8724109 [details]
MozReview Request: Bug 1251629 - remove unused reference to PREDICTOR_TESTS in netwerk/base/moz.build. r?hurley

https://reviewboard.mozilla.org/r/36861/#review33443
(In reply to Joel Maher (:jmaher) from comment #2)
> a try run seems overkill.

Famous last words ;)
ok, try run pushed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cfaccc23435

I have been backed out too many times for silly things!  I will land after the try run looks good :)

thanks for the really quick review!
https://hg.mozilla.org/mozilla-central/rev/cc2fbc172cc0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.