Closed Bug 1251652 Opened 5 years ago Closed 5 years ago

Add pushdate, pushid and pushuser in json-changeset

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: calixte, Assigned: calixte)

References

()

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8724155 [details]
MozReview Request: Bug 1251652 - Add pushdate, pushid and pushuser in json-changeset; r?gps

https://reviewboard.mozilla.org/r/36891/#review33559

This is mostly good. Thank you for writing the test!

::: hgext/hgmo/tests/test-json-changeset.t:50
(Diff revision 1)
> +      "pushdate": [
> +          0, 
> +          0
> +      ], 

Instead of rewriting the JSON above, you can do regular expression matching in .t tests:

   "pushdate": [
       \d+,  (re)
       \d+ (re)
   ],
   
(Note the double space before that first `(re)` - one space is swallowed for "(re)" the other denotes the trailing space in the raw output. I wish Python's JSON formatter didn't print that trailing whitespace...

::: hgext/hgmo/tests/test-json-changeset.t:55
(Diff revision 1)
> +      "pushuser": "calixte", 

You need to `export USER=hguser` or some such at the top of the .t file so the test is deterministic.
Attachment #8724155 - Flags: review?(gps)
Comment on attachment 8724155 [details]
MozReview Request: Bug 1251652 - Add pushdate, pushid and pushuser in json-changeset; r?gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36891/diff/1-2/
Attachment #8724155 - Flags: review?(gps)
Attachment #8724155 - Flags: review?(gps) → review+
Comment on attachment 8724155 [details]
MozReview Request: Bug 1251652 - Add pushdate, pushid and pushuser in json-changeset; r?gps

https://reviewboard.mozilla.org/r/36891/#review34027

LGTM. I'll land and deploy this.
Deploying now.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.