Closed
Bug 1251652
Opened 6 years ago
Closed 6 years ago
Add pushdate, pushid and pushuser in json-changeset
Categories
(Developer Services :: Mercurial: hg.mozilla.org, defect)
Developer Services
Mercurial: hg.mozilla.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: calixte, Assigned: calixte)
References
()
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36891/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36891/
Attachment #8724155 -
Flags: review?(gps)
Comment 2•6 years ago
|
||
Comment on attachment 8724155 [details] MozReview Request: Bug 1251652 - Add pushdate, pushid and pushuser in json-changeset; r?gps https://reviewboard.mozilla.org/r/36891/#review33559 This is mostly good. Thank you for writing the test! ::: hgext/hgmo/tests/test-json-changeset.t:50 (Diff revision 1) > + "pushdate": [ > + 0, > + 0 > + ], Instead of rewriting the JSON above, you can do regular expression matching in .t tests: "pushdate": [ \d+, (re) \d+ (re) ], (Note the double space before that first `(re)` - one space is swallowed for "(re)" the other denotes the trailing space in the raw output. I wish Python's JSON formatter didn't print that trailing whitespace... ::: hgext/hgmo/tests/test-json-changeset.t:55 (Diff revision 1) > + "pushuser": "calixte", You need to `export USER=hguser` or some such at the top of the .t file so the test is deterministic.
Attachment #8724155 -
Flags: review?(gps)
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8724155 [details] MozReview Request: Bug 1251652 - Add pushdate, pushid and pushuser in json-changeset; r?gps Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36891/diff/1-2/
Attachment #8724155 -
Flags: review?(gps)
Updated•6 years ago
|
Attachment #8724155 -
Flags: review?(gps) → review+
Comment 4•6 years ago
|
||
Comment on attachment 8724155 [details] MozReview Request: Bug 1251652 - Add pushdate, pushid and pushuser in json-changeset; r?gps https://reviewboard.mozilla.org/r/36891/#review34027 LGTM. I'll land and deploy this.
Comment 5•6 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/2d9ac7fd02af81a26a5b32a50e09322b552fb689 hgmo: use json-rev URLs (bug 1251652)
Comment 6•6 years ago
|
||
https://hg.mozilla.org/hgcustom/version-control-tools/rev/2a4814a92f10f733cd0b5efc57fc7789b5066fb9 hgserver: add pushlog to test output (bug 1251652)
Comment 7•6 years ago
|
||
Deploying now.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•