Closed
Bug 1251692
Opened 10 years ago
Closed 10 years ago
Remove AddonListener after install in marionette_driver.addons
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox46 fixed, firefox47 fixed)
RESOLVED
FIXED
mozilla46
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(1 file)
There should be a call to AddonManager.removeAddonListener() here:
https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/addons.py#68
| Assignee | ||
Comment 1•10 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36895/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36895/
Attachment #8724158 -
Flags: review?(ato)
Comment 2•10 years ago
|
||
Comment on attachment 8724158 [details]
MozReview Request: Bug 1251692 - Remove AddonListener after marionette_driver.addons.install, r?ato
https://reviewboard.mozilla.org/r/36895/#review33481
LGTM.
Please note that bug 1246407 renames the _testing/marionette/driver_ directory to _testing/marionette/harness_ and that this will likely require you to rebase.
Attachment #8724158 -
Flags: review?(ato) → review+
| Assignee | ||
Comment 4•10 years ago
|
||
Hooray for autoland and not needing to rebase \o/
Comment 5•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
| Assignee | ||
Comment 6•10 years ago
|
||
status-firefox46:
--- → fixed
Target Milestone: mozilla47 → mozilla46
Updated•3 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•