Closed Bug 1251702 Opened 8 years ago Closed 8 years ago

Remove loopbackAudio for jobs that don't need it

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: armenzg, Assigned: armenzg)

Details

Attachments

(1 file)

It seems I started pushing around the loopbackAudio feature around without really being required.

I've pushed a change to remove it from all jobs and see which actually need it [1].

I will also try removing loopbackVideo, however, I doubt that one will yield a lot of jobs I can disable it from.

ahal: do you remember which job failed?

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=5484e4bcd833&group_state=expanded
I only see this reference about audio and patctl in here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1171033#c13
Assignee: nobody → armenzg
Attachment #8724171 - Flags: review?(ahalberstadt)
I've pushed again with a more recent base since the first try push was old (which came back green except for a couple of old perma oranges).
This is only used for Mochitest jobs, FYI, and only if the job passes --use-test-media-devices, which is maybe all Mochitests:
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/unittests/linux_unittest.py#132
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5)
> This is only used for Mochitest jobs, FYI, and only if the job passes
> --use-test-media-devices, which is maybe all Mochitests:
> https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/
> unittests/linux_unittest.py#132

I thought all mochitests would have failed, however, that has not been the case:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5484e4bcd833&group_state=expanded
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb939be015b2&group_state=expanded

And I see it being used in the logs [1]

[1]
https://public-artifacts.taskcluster.net/c2-znkEdSvyulCPMRw2Qlg/0/public/logs/live_backing.log
/home/worker/workspace/build/venv/bin/python -u /home/worker/workspace/build/tests/mochitest/runtests.py --total-chunks 10 --this-chunk 2 --appname=/home/worker/workspace/build/application/firefox/firefox --utility-path=tests/bin --extra-profile-file=tests/bin/plugins --symbols-path=https://queue.taskcluster.net/v1/task/Md4psL5aR_qKWJnOsZl9Ng/artifacts/public/build/target.crashreporter-symbols.zip --certificate-path=tests/certs --setpref=webgl.force-enabled=true --quiet --log-raw=/home/worker/workspace/build/blobber_upload_dir/plain-chunked_raw.log --log-errorsummary=/home/worker/workspace/build/blobber_upload_dir/plain-chunked_errorsummary.log --use-test-media-devices --screenshot-on-fail --chunk-by-dir=4
I'd have to go back and look at the docker-worker source to remember exactly what loopbackAudio does, but I think it's possible that the Mochitest code for --use-test-media-devices doesn't actually require it:
https://dxr.mozilla.org/mozilla-central/rev/5e0140b6d11821e0c2a2de25bc5431783f03380a/testing/mochitest/runtests.py#1452

That code just wants a functioning PulseAudio setup, makes PA load an audio source module that provides a sine wave, and then forces the browser to use that device. I don't *think* that requires us to have a working audio device under /dev/, but I don't honestly know for sure.
Comment on attachment 8724171 [details] [diff] [review]
Remove loopbackAudio from TC Firefox test jobs

Review of attachment 8724171 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm!
Attachment #8724171 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/906d37906930
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: