1251720 - Remove Storage Inspector directory from .eslintignore

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect)

Description

[Tim Nguyen :ntim]

The storage inspector is eslint clean.

Comment 1

[Tim Nguyen :ntim]

Attachment: patch

Comment 2

[Tim Nguyen :ntim]

ESLint try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e3f0afeb9ec

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8724196 [details] [diff] [review]
patch

Review of attachment 8724196 [details] [diff] [review]:
-----------------------------------------------------------------

Oh wow, the whole directory is already clean? That's awesome, I didn't know.
Just to double check, make sure you either run eslint with 'mach eslint' locally or push to try with an eslint task if you haven't done so already. ESlint is run with a specific configuration that may pick up errors that you might not have seen.

r=me if try is green

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5592b9a4cad6

Comment 5

[Patrick Brosset <:pbro>]

(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #3)
> Comment on attachment 8724196 [details] [diff] [review]
> patch
> 
> Review of attachment 8724196 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Oh wow, the whole directory is already clean?
Well of course it is ... I have reviewed a patch last week with eslint cleanups, I guess I had forgotten already :)
Too many reviews ... and being sick doesn't help either.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5592b9a4cad6