1251722 - WorkerPrivate::Freeze/Thaw are called with null windows from sharedworker code but comments say that can't happen

Status: NEW

(Core :: DOM: Workers, defect, P5)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 1251045 comment 12.  

The passing of null goes all the way back to 643325, which is when the window argument was added.

The comment claiming null can't be passed goes back to bug 1092102.  So I think the comment is more likely to be wrong.

Comment 1

[Eddy Bruel [:ejpbruel]]

(In reply to Boris Zbarsky [:bz] from comment #0)
> See bug 1251045 comment 12.  
> 
> The passing of null goes all the way back to 643325, which is when the
> window argument was added.
> 
> The comment claiming null can't be passed goes back to bug 1092102.  So I
> think the comment is more likely to be wrong.

That comment is from before I started working on this code, so I have no idea if it's supposed to be true or not. Our best bet is probably to ask Kyle here.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Er... you added the comment in bug 1092102, no?

Comment 3

[Eddy Bruel [:ejpbruel]]

(In reply to Boris Zbarsky [:bz] from comment #2)
> Er... you added the comment in bug 1092102, no?

If memory serves, I only renamed Suspend/Resume to Freeze/Thaw in that bug. I changed the comment to reflect those new names, but I did not write the original. See the patch at: https://bug1092102.bmoattachments.org/attachment.cgi?id=8581798

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The comment is probably wrong, and might just predate SharedWorkers entirely.