Closed Bug 1251723 Opened 4 years ago Closed 4 years ago

remove ScopedDeletePtr

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

UniquePtr is more standard than ScopedDeletePtr; using standard
constructs whenever possible is preferable.
It's worth pointing out that this patch depends on several other in-flight bugs
to work correctly.  I promise not to break the tree with this patch until the
other bugs are resolved. :)
Attachment #8724186 - Flags: review?(jwalden+bmo)
Comment on attachment 8724186 [details] [diff] [review]
remove ScopedDeletePtr

Review of attachment 8724186 [details] [diff] [review]:
-----------------------------------------------------------------

\o/  I'd occasionally been doing this to JS's ScopedDeletePtr (added before template aliases were a thing), nice to see it happening to the original too.  This whole header needs to die, really.
Attachment #8724186 - Flags: review?(jwalden+bmo) → review+
Depends on: 1253571
https://hg.mozilla.org/mozilla-central/rev/1b90b677dab3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.