Intermittent test_bug879717.html,test_streams_element_capture_reset.html,test_streams_autoplay.html | application crashed [@ mozilla::layers::BufferTextureHost::PrepareTextureSource] or application crashed [None]

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: KWierso, Assigned: sotaro)

Tracking

({intermittent-failure})

47 Branch
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed, firefox48 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment, 1 obsolete attachment)

Looks like a gfx bug.
Component: Audio/Video → Graphics: Layers
Nical, in the second report, looks like it is crashing here: https://dxr.mozilla.org/mozilla-central/source/gfx/layers/composite/TextureHost.cpp#546

mCompositor seems null there at the time PrepareTextureSource is called.

Seems regression happened with: 
https://hg.mozilla.org/mozilla-central/rev/eced4790cbdc
Flags: needinfo?(nical.bugzilla)
Whiteboard: [gfx-noted]
See Also: → 1249273
See Also: → 1251427
Comment on attachment 8726690 [details] [diff] [review]
patch - Make sure and check if Compositor is set.

milan, can you review the patch?
Attachment #8726690 - Flags: review?(milan)
Attachment #8726690 - Flags: review?(milan)
Attachment #8726690 - Attachment is obsolete: true
Attachment #8726723 - Flags: review?(nical.bugzilla)
Summary: Intermittent test_streams_element_capture_reset.html | application crashed [@ mozilla::layers::BufferTextureHost::PrepareTextureSource] or application crashed [None] → Intermittent test_bug879717.html,test_streams_element_capture_reset.html | application crashed [@ mozilla::layers::BufferTextureHost::PrepareTextureSource] or application crashed [None]
Attachment #8726723 - Flags: review?(nical.bugzilla) → review+
Summary: Intermittent test_bug879717.html,test_streams_element_capture_reset.html | application crashed [@ mozilla::layers::BufferTextureHost::PrepareTextureSource] or application crashed [None] → Intermittent test_bug879717.html,test_streams_element_capture_reset.html,test_streams_autoplay.html | application crashed [@ mozilla::layers::BufferTextureHost::PrepareTextureSource] or application crashed [None]
Assignee: nobody → sotaro.ikeda.g
Flags: needinfo?(nical.bugzilla)
https://hg.mozilla.org/mozilla-central/rev/185e10fbb9d3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Please nominate this for Aurora approval when you get a chance.
Flags: needinfo?(sotaro.ikeda.g)
Blocks: 1249273
Flags: needinfo?(sotaro.ikeda.g)
Comment on attachment 8726723 [details] [diff] [review]
patch - Check if Compositor is set

Approval Request Comment
[Feature/regressing bug #]: Bug 1249273
[User impact if declined]: It could cause the crash during starting firefox.
[Describe test coverage new/current, TreeHerder]: landed to m-c.
[Risks and why]: low. It just added pointer check.
[String/UUID change made/needed]:none
Attachment #8726723 - Flags: approval-mozilla-aurora?
Comment on attachment 8726723 [details] [diff] [review]
patch - Check if Compositor is set

fixes an intermittent, taking it.
Attachment #8726723 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.