1251749 - Use UI telemetry to tell if settings are enabled or not

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, defect)

Description

[:Margaret Leibovic]

Right now we use UI telemetry to tell whether or not people tap on items in settings, but that's not actually what we want to know.

We use histogram probes to collect that value of certain individual settings, but it's burdensome to add that for every new setting, as well as expensive on data to continue to add histograms.

We should change our current settings UI telemetry to indicate the value of the setting when it's changed. Mark, do you know what we could send to make analysis simple here?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I accidentally commented about this very thing here: https://bugzilla.mozilla.org/show_bug.cgi?id=1251454#c2

Comment 2

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> I accidentally commented about this very thing here:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1251454#c2

For completeness:

(In reply to Mark Finkle (:mfinkle) from comment #2)
> I would like us to move away from histograms and look for event data ways to
> capture this data. I think it's more useful to look at what people are
> changing in relation to other events. Examples:
> 
> 1. Saw onboarding talk about data saver, and soon after turn it on (never or
> wifi)
> 2. Saw a prompt for Tab Queues and turned it on (boolean)
> 3. Saw a notification for updated content, didn't like it and turned it off
> (via the settings button)
> 
> We track event probes for any changes to preferences: (edit.1, settings,
> name-of-pref). I wonder how useful it would be to change to: (edit.1,
> settings, ["name-of-pref", "value"])
>
> where value would be (0, 1) for booleans, integer for modes, and "*" for
> user entered strings? I used "*" because we need to be careful with data
> that could uniquely identify someone.
> 
> SQL and Spark are both capable of "unpacking" the array, if needed.

Let's write a patch! This is a single line that needs changing:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#1206

Comment 4

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1251749 - Use UI telemetry to tell if settings are enabled or not. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/43589/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43589/

Comment 5

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #2)

> > where value would be (0, 1) for booleans, integer for modes, and "*" for
> > user entered strings? I used "*" because we need to be careful with data
> > that could uniquely identify someone.

Many of our settings are actually string types, so I didn't want to store "*" for all strings. I did an audit of the settings to look for places where users can enter text, and I believe the homepage preference is the only place, so I special-cased that.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8736911 [details]
MozReview Request: Bug 1251749 - Use UI telemetry to tell if settings are enabled or not. r=sebastian

https://reviewboard.mozilla.org/r/43589/#review40619

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/71d3427c683190cdb409063ad67e24d5926f4591
Bug 1251749 - Use UI telemetry to tell if settings are enabled or not. r=sebastian

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/71d3427c6831