improve release sanity timing for en-US binaries by blacklisting some of the artifacts

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mtabara, Assigned: mtabara)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Below is a full list of artifacts that are generated within linux en-US binary. Some of them can be trimmed to improve the timing of this step:

public/build/buildbot_properties.json
public/build/buildprops.json
public/build/firefox-47.0.en-US.langpack.xpi
public/build/firefox-47.0.en-US.linux-i686.checksums
public/build/firefox-47.0.en-US.linux-i686.checksums.asc
public/build/firefox-47.0.en-US.linux-i686.common.tests.zip
public/build/firefox-47.0.en-US.linux-i686.complete.mar
public/build/firefox-47.0.en-US.linux-i686.cppunittest.tests.zip
public/build/firefox-47.0.en-US.linux-i686.crashreporter-symbols.zip
public/build/firefox-47.0.en-US.linux-i686.gtest.tests.zip
public/build/firefox-47.0.en-US.linux-i686.json
public/build/firefox-47.0.en-US.linux-i686.mochitest.tests.zip
public/build/firefox-47.0.en-US.linux-i686.mozinfo.json
public/build/firefox-47.0.en-US.linux-i686.reftest.tests.zip
public/build/firefox-47.0.en-US.linux-i686.sdk.tar.bz2
public/build/firefox-47.0.en-US.linux-i686.sdk.tar.bz2.asc
public/build/firefox-47.0.en-US.linux-i686.talos.tests.zip
public/build/firefox-47.0.en-US.linux-i686.tar.bz2
public/build/firefox-47.0.en-US.linux-i686.txt
public/build/firefox-47.0.en-US.linux-i686.web-platform.tests.zip
public/build/firefox-47.0.en-US.linux-i686.xpcshell.tests.zip
public/build/firefox-47.0.en-US.linux-i686_info.txt
public/build/jsshell-linux-i686.zip
public/build/log_critical.log
public/build/log_error.log
public/build/log_fatal.log
public/build/log_info.log
public/build/log_raw.log
public/build/log_warning.log
public/build/mar
public/build/mbsdiff
public/build/mozharness.zip
public/build/test_packages.json
Whitelist these file extensions and trim the others for time improvement

* complete.mar
* any .exe
* .dmg
* i686.tar.bz2
* x86_64.tar.bz2
Whitelist everything but the installers, complete mars and checksums
Attachment #8724336 - Flags: review?(rail)
Comment on attachment 8724336 [details] [diff] [review]
Whitelist part of en-US artifacts

Review of attachment 8724336 [details] [diff] [review]:
-----------------------------------------------------------------

Just a nit:

::: buildfarm/release/release-runner.py
@@ +294,5 @@
>  
> +    # get all artifacts
> +    _ = queue.listLatestArtifacts(task_id)['artifacts']
> +    # trim but 'name' field from the json entries
> +    all_artifacts = [k['name'] for k in _]

Can you combine the 2 lines above so you don't use _?

Something like
  all_artifacts = [k['name'] for k in queue.listLatestArtifacts(task_id)['artifacts']]
Attachment #8724336 - Flags: review?(rail) → review+
Refactoring per Rail's comments.
Attachment #8724336 - Attachment is obsolete: true
Attachment #8724342 - Flags: review?(rail)
Refactoring per Rail's comments.
Attachment #8724347 - Flags: review?(rail)
Attachment #8724342 - Attachment is obsolete: true
Attachment #8724342 - Flags: review?(rail)
Attachment #8724347 - Flags: review?(rail) → review+
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.