Closed
Bug 1251790
Opened 8 years ago
Closed 8 years ago
Add help for "interface objects"
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
7.15 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
I have been trying to separate out the blob of shell functions into separate pieces (eg "os", "os.file", etc.). But currently, the help system won't display anything in those, so they're kind of hidden.
Assignee | ||
Comment 1•8 years ago
|
||
Also, the way help is done is kinda weird -- if eg you have a primitive property on the global, help() will end up throwing. With this patch, 'os' will show up in the global help() output (just listing its members). It's still pretty clunky, but it seems like the minimum change that'll do the job. I started on another scheme, but then realized it should really be self-hosted (too much groveling through JS datastructures from C++), and that seemed like far too much for this silly bug.
Attachment #8724335 -
Flags: review?(terrence)
Comment 2•8 years ago
|
||
Comment on attachment 8724335 [details] [diff] [review] Add help for "interface objects" Review of attachment 8724335 [details] [diff] [review]: ----------------------------------------------------------------- WFM.
Attachment #8724335 -
Flags: review?(terrence) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b0cd29d16e6c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•