Closed Bug 1251790 Opened 8 years ago Closed 8 years ago

Add help for "interface objects"

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

I have been trying to separate out the blob of shell functions into separate pieces (eg "os", "os.file", etc.). But currently, the help system won't display anything in those, so they're kind of hidden.
Also, the way help is done is kinda weird -- if eg you have a primitive property on the global, help() will end up throwing.

With this patch, 'os' will show up in the global help() output (just listing its members).

It's still pretty clunky, but it seems like the minimum change that'll do the job. I started on another scheme, but then realized it should really be self-hosted (too much groveling through JS datastructures from C++), and that seemed like far too much for this silly bug.
Attachment #8724335 - Flags: review?(terrence)
Comment on attachment 8724335 [details] [diff] [review]
Add help for "interface objects"

Review of attachment 8724335 [details] [diff] [review]:
-----------------------------------------------------------------

WFM.
Attachment #8724335 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/b0cd29d16e6c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: