Closed Bug 1251808 Opened 4 years ago Closed 4 years ago

RasterImage::GetCurrentImage() should handle the case where the surface size is different from the intrinsic size

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(2 files)

Currently, RasterImage::GetCurrentImage() creates a SourceSurfaceImage sized to the intrinsic size of the image, even if the actual SourceSurface it has is a different size due to e.g. downscale-during-decode. We should use the actual SourceSurface size when constructing the SourceSurfaceImage.

This bug is a transplant of Matt Woodrow's patch from bug 1225934, since the patch does not actually fix that bug, but *does* fix a real issue.
Here's the patch that Matt provided in bug 1225934. He requested review from me
there, so I'm r+'ing it here.

(Unfortunately in the git/hg round trip I have messed up the commit author; in
the interest of getting this issue fixed quickly I haven't worried about fixing
that. But this is Matt's patch, unchanged.)
Attachment #8724357 - Flags: review?(seth)
Attachment #8724357 - Flags: review?(seth) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/39a1e216208199904ef3a562eb5d643efc08223d
Bug 1251808 - Construct the SourceSurfaceImage with the correct size in RasterImage::GetCurrentImage(). r=seth
Unfortunately the original patch neglected to mark the new single-argument
constructor explicit. Here's a quick followup to do that.
https://hg.mozilla.org/integration/mozilla-inbound/rev/debf6c7316b7a0514dbf2c85bb7df4b4a40d5972
Bug 1251808 (Followup) - Mark the new SourceSurfaceImage constructor explicit. r=me
https://hg.mozilla.org/mozilla-central/rev/39a1e2162081
https://hg.mozilla.org/mozilla-central/rev/debf6c7316b7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.