Closed Bug 1251810 Opened 4 years ago Closed 4 years ago

Arch pacman -U command in bootstrap ignore --no-interactive flag

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: qheaden, Assigned: qheaden)

Details

Attachments

(1 file)

When the bootstrap script installs an AUR package, it runs pacman -U <package archive> after building the package with makepkg. pacman -U shows a confirmation prompt by default, and the --no-interactive flag does not pass --noconfirm to the update command.

Bug 1251352 fixed the pacman -S command.
Assignee: nobody → qheaden
Attached patch patch-1Splinter Review
This patch handles the ignoring of --no-interactive during the install of AUR packages.
Attachment #8724363 - Flags: review?(gps)
Comment on attachment 8724363 [details] [diff] [review]
patch-1

Review of attachment 8724363 [details] [diff] [review]:
-----------------------------------------------------------------

Cool. Will land this for you.
Attachment #8724363 - Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/be04c2a93d86615734d24b7ed11b6b67de82f60d
Bug 1251810 - Update Arch pacman -U command in bootstrap to handle --no-interactive; r=gps
https://hg.mozilla.org/mozilla-central/rev/be04c2a93d86
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.