Closed Bug 1251835 Opened 5 years ago Closed 5 years ago

Style the netError like the FX netError page

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed)

RESOLVED FIXED
Thunderbird 47.0
Tracking Status
thunderbird45 --- fixed
thunderbird46 --- fixed
thunderbird47 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(4 files)

The global netError page uses still the old appearance. All other content pages use the new in-content styling.

Because SM doesn't want the new styling, we can use an override of our own netError.css.
Attached patch netError.patchSplinter Review
I'm overriding the global netError.css with our own aboutNetError.css file. Like this SM isn't affected by this change. FX made the same but also with netError.xhtml and expanded it.

The file has still #brand rules but I haven't seen references where this is used. Magnus, do you know where this is used? Or could I remove this?

Not new in this bug but on a failed secure connection where is a link at the bottom, which better should be a button, to show more details. But this link doesn't work because of the disabling of JS in this content. What do you think, should I hide this link to not irritate the user by the not working link? Or is it somehow possible to make it working?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8724410 - Flags: review?(mkmelin+mozilla)
Attached image New netError page
On bottom is the not working link.
Attached image Blacklisted page
Please don't check the text content. I only added the blacklist class through DOMi to the normal netError page. I had no blacklisted page at hand.

Important are the colors and the icon.
(In reply to Richard Marti (:Paenglab) from comment #1)
> The file has still #brand rules but I haven't seen references where this is
> used. Magnus, do you know where this is used? Or could I remove this?

Likely it's unused, but might be safer to leave it in still (for now and future usage).

> Not new in this bug but on a failed secure connection where is a link at the
> bottom, which better should be a button, to show more details. But this link
> doesn't work because of the disabling of JS in this content. What do you
> think, should I hide this link to not irritate the user by the not working
> link? Or is it somehow possible to make it working?

The "Try again" button works, so I we should try to make it work. Please file a new bug for that.
Attachment #8724410 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
(In reply to Magnus Melin from comment #5)
> The "Try again" button works, so I we should try to make it work. Please
> file a new bug for that.

Filed bug 1252991
http://hg.mozilla.org/comm-central/rev/0cd048db58c2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
Comment on attachment 8724410 [details] [diff] [review]
netError.patch

[Approval Request Comment]
User impact if declined: no impact, new appearance looks more modern
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8724410 - Flags: approval-comm-beta?
Attachment #8724410 - Flags: approval-comm-aurora?
Attachment #8724410 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 8724410 [details] [diff] [review]
netError.patch

http://hg.mozilla.org/releases/comm-esr45/rev/8b07a1f00634
Attachment #8724410 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #8724410 - Flags: approval-comm-beta+ → approval-comm-esr45+
You need to log in before you can comment on or make changes to this bug.