1251835 - Style the netError like the FX netError page

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The global netError page uses still the old appearance. All other content pages use the new in-content styling.

Because SM doesn't want the new styling, we can use an override of our own netError.css.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: netError.patch

I'm overriding the global netError.css with our own aboutNetError.css file. Like this SM isn't affected by this change. FX made the same but also with netError.xhtml and expanded it.

The file has still #brand rules but I haven't seen references where this is used. Magnus, do you know where this is used? Or could I remove this?

Not new in this bug but on a failed secure connection where is a link at the bottom, which better should be a button, to show more details. But this link doesn't work because of the disabling of JS in this content. What do you think, should I hide this link to not irritate the user by the not working link? Or is it somehow possible to make it working?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: New netError page

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Secure connection failed page

On bottom is the not working link.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Blacklisted page

Please don't check the text content. I only added the blacklist class through DOMi to the normal netError page. I had no blacklisted page at hand.

Important are the colors and the icon.

Comment 5

[Magnus Melin [:mkmelin]]

(In reply to Richard Marti (:Paenglab) from comment #1)
> The file has still #brand rules but I haven't seen references where this is
> used. Magnus, do you know where this is used? Or could I remove this?

Likely it's unused, but might be safer to leave it in still (for now and future usage).

> Not new in this bug but on a failed secure connection where is a link at the
> bottom, which better should be a button, to show more details. But this link
> doesn't work because of the disabling of JS in this content. What do you
> think, should I hide this link to not irritate the user by the not working
> link? Or is it somehow possible to make it working?

The "Try again" button works, so I we should try to make it work. Please file a new bug for that.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Magnus Melin from comment #5)
> The "Try again" button works, so I we should try to make it work. Please
> file a new bug for that.

Filed bug 1252991

Comment 7

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/0cd048db58c2

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 8724410 [details] [diff] [review]
netError.patch

[Approval Request Comment]
User impact if declined: no impact, new appearance looks more modern
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Jorg K (CEST = GMT+2)]

Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/2ede514994d3

Comment 10

[Kent James (:rkent)]

Comment on attachment 8724410 [details] [diff] [review]
netError.patch

http://hg.mozilla.org/releases/comm-esr45/rev/8b07a1f00634