[Devtool] Request URL should not include URL fragment identifier

RESOLVED FIXED in Firefox 58

Status

DevTools
Netmonitor
P3
normal
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: schien, Assigned: Abhinav Koppula, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 58
good-first-bug

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [good first bug][mentor-lang=zh][lang=js])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

[STR]
1. open a new tab and turn on Network Monitor
2. open http://www.example.org/#test in this tab
3. check the "Request URL" for the first HTTP request

[Expected]
The Request URL should be http://www.example.org/ without the URL fragment identifier (i.e. #test) because the real HTTP request doesn't include this part.

[Actual]
The Request URL shows http://www.example.org/#test
Has STR: --- → yes
Priority: -- → P3

Comment 1

9 months ago
We could call `new URL(link).origin` in HeadersPanel to return the correct Request URL

https://developer.mozilla.org/en-US/docs/Web/API/URL/origin
Mentor: gasolin
Keywords: good-first-bug
Whiteboard: [good first bug][mentor-lang=zh][lang=js]
Comment hidden (mozreview-request)
(Assignee)

Comment 3

9 months ago
Hi Fred,
I have created a mozreview-request for this issue and have also modified the tests a bit.
Can you please take a look once?

Updated

9 months ago
Assignee: nobody → abhinav.koppula
Status: NEW → ASSIGNED

Comment 4

9 months ago
mozreview-review
Comment on attachment 8921573 [details]
Bug 1251836 - Request URL should not include URL fragment identifier.

https://reviewboard.mozilla.org/r/192590/#review197970

looks good, thanks!
Attachment #8921573 - Flags: review?(gasolin) → review+

Comment 5

9 months ago
Pushed by flin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc0e0f8ae786
Request URL should not include URL fragment identifier. r=gasolin
https://hg.mozilla.org/mozilla-central/rev/fc0e0f8ae786
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.