1251836 - [Devtool] Request URL should not include URL fragment identifier

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

[STR]
1. open a new tab and turn on Network Monitor
2. open http://www.example.org/#test in this tab
3. check the "Request URL" for the first HTTP request

[Expected]
The Request URL should be http://www.example.org/ without the URL fragment identifier (i.e. #test) because the real HTTP request doesn't include this part.

[Actual]
The Request URL shows http://www.example.org/#test

Comment 1

[[e-mail]]

We could call `new URL(link).origin` in HeadersPanel to return the correct Request URL

https://developer.mozilla.org/en-US/docs/Web/API/URL/origin

Comment 2

[Abhinav Koppula]

Attachment: Bug 1251836 - Request URL should not include URL fragment identifier.

Review commit: https://reviewboard.mozilla.org/r/192590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192590/

Comment 3

[Abhinav Koppula]

Hi Fred,
I have created a mozreview-request for this issue and have also modified the tests a bit.
Can you please take a look once?

Comment 4

[[e-mail]]

Comment on attachment 8921573 [details]
Bug 1251836 - Request URL should not include URL fragment identifier.

https://reviewboard.mozilla.org/r/192590/#review197970

looks good, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc0e0f8ae786
Request URL should not include URL fragment identifier. r=gasolin

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fc0e0f8ae786