Closed
Bug 1251845
Opened 10 years ago
Closed 10 years ago
We should only generate performance alerts on specific repositories
Categories
(Tree Management :: Perfherder, defect)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
References
Details
Attachments
(1 file)
Right now we generate alerts on any repository not marked as a try repository, but there are some cases (e.g. b2g-inbound) where we don't want to do this. We should probably add a property to the repository model on whether we should generate performance alerts for it (default False).
Relevant code in:
treeherder/model/models.py
treeherder/etl/perf.py
Comment 1•10 years ago
|
||
do we have more work to do here? I thought we had turned this off everywhere we don't want it.
| Assignee | ||
Comment 2•10 years ago
|
||
We have no formal support for this yet, so this is probably still relevant (albeit low priority).
Comment 3•10 years ago
|
||
| Assignee | ||
Updated•10 years ago
|
Attachment #8740483 -
Flags: review?(jmaher)
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → wlachance
Comment 5•10 years ago
|
||
Comment on attachment 8740483 [details] [review]
[treeherder] wlach:1251845 > mozilla:master
nice!
Attachment #8740483 -
Flags: review?(jmaher) → review+
Comment 6•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla/treeherder/commit/c552b4774f9e6eceefd5f326652e7368aeb858ca
Comment 7•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/3bf0fefd0fe4187c517c29a3f160af3e68678266
Bug 1251845 - Only generate performance alerts on specific repositories
Make a repository property on whether we should generate performance alerts,
default to false.
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•