1251870 - Disable content indexing on objdir on Windows

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Patch to be posted shortly...

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1251870 - Disable indexing of objdir on Windows; r?ted

The Windows content indexing service has been known to scan the objdir.
This can add significant system overhead and slow down builds or
subsequent operations. The objdir is meant to be a short-lived black box
and there really isn't a major benefit to indexing it.

There is a file attribute on Windows that disables content indexing.
This commit adds a utility function for creating a directory and
optionally disabling indexing on it. We call it at the top of
`mach build` to ensure the objdir as content indexing disabled.

Review commit: https://reviewboard.mozilla.org/r/37027/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37027/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8724445 [details]
MozReview Request: Bug 1251870 - Disable indexing of objdir on Windows; r?ted

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37027/diff/1-2/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8724445 [details]
MozReview Request: Bug 1251870 - Disable indexing of objdir on Windows; r?ted

https://reviewboard.mozilla.org/r/37027/#review33659

::: python/mozbuild/mozbuild/util.py:124
(Diff revision 2)
> +    indexing on the directory.

Should we make this support the Spotlight workaround as well for OS X?
https://dxr.mozilla.org/mozilla-central/rev/5e0140b6d11821e0c2a2de25bc5431783f03380a/python/mozbuild/mozbuild/mach_commands.py#62

Comment 4

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/37027/#review33659

> Should we make this support the Spotlight workaround as well for OS X?
> https://dxr.mozilla.org/mozilla-central/rev/5e0140b6d11821e0c2a2de25bc5431783f03380a/python/mozbuild/mozbuild/mach_commands.py#62

I was going to file a follow-up for that. That's why I indended the code the way I did.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7769b2dc2bd

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b7769b2dc2bd