All users were logged out of Bugzilla on October 13th, 2018

Remove remaining Cu.importGlobalProperties from devtools

RESOLVED INVALID

Status

P3
normal
RESOLVED INVALID
3 years ago
4 months ago

People

(Reporter: pbro, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
In bug 1223452 Tom removed a bunch of Cu.importGlobalProperties.
Today I found 2 more:

\devtools\server\actors\device.js:
   15: Cu.importGlobalProperties(["FileReader"]);

\devtools\server\actors\webapps.js:
   14: Cu.importGlobalProperties(["FileReader"]);

We should get rid of these too I guess.

Tom, what do you suggest we replace these with?
(Reporter)

Updated

3 years ago
Flags: needinfo?(ttromey)
I would like to work on this after Tom specifies what the replacement is.

Comment 2

3 years ago
I think the simplest thing is to make a new "FileReader" module in Loader.jsm.
You can follow the CSS example here:

https://dxr.mozilla.org/mozilla-central/source/devtools/shared/Loader.jsm#70

I really thought I had gotten all the calls; kind of surprised that this
wasn't found during bug 1224289.
Flags: needinfo?(ttromey)
As far as I can see, these are removed now, so there's nothing left to do here.
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → INVALID

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.