Closed Bug 1251910 Opened 4 years ago Closed 4 years ago

IOSurface YUV422 support broken

Categories

(Core :: Audio/Video: Playback, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1249273 reverted all the important changes of bug 1248323 :(
Blocks: 1249273
this causes a null deref when the decoder output YUV422

* thread #32: tid = 0x3ccdb3, 0x0000000103f25cf1 XUL`RefPtr<mozilla::layers::TexturedEffect>::operator->(this=0x0000700001b08ce8) const + 97 at RefPtr.h:296, name = 'Compositor', stop reason = EXC_BAD_ACCESS (code=1, address=0x0)
  * frame #0: 0x0000000103f25cf1 XUL`RefPtr<mozilla::layers::TexturedEffect>::operator->(this=0x0000700001b08ce8) const + 97 at RefPtr.h:296
    frame #1: 0x0000000103f26920 XUL`mozilla::layers::CreateTexturedEffect(aFormat=YUV422, aSource=0x000060800109d1a0, aFilter=0x0000700001b09087, isAlphaPremultiplied=true, state=0x0000700001b08f70) + 496 at Effects.h:285
    frame #2: 0x0000000103f14f02 XUL`mozilla::layers::ImageHost::Composite(this=0x0000608002312e10, aLayer=0x0000000190faa8a0, aEffectChain=0x0000700001b09450, aOpacity=1, aTransform=0x0000000190faab08, aFilter=0x0000700001b09087, aClipRect=0x0000700001b09430, aVisibleRegion=0x0000000000000000) + 1250 at ImageHost.cpp:360
    frame #3: 0x0000000103f2006d XUL`mozilla::layers::ImageLayerComposite::RenderLayer(this=0x0000700001b09508, effectChain=0x0000700001b09450, clipRect=0x0000700001b09430)::$_2::operator()(mozilla::layers::EffectChain&, mozilla::gfx::RectTyped<mozilla::gfx::UnknownUnits, float> const&) const + 269 at ImageLayerComposite.cpp:100
    frame #4: 0x0000000103f1748f XUL`void mozilla::layers::RenderWithAllMasks<mozilla::layers::ImageLayerComposite::RenderLayer(mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&)::$_2>(aLayer=0x0000000190faa8a0, aCompositor=0x000000012774c570, aClipRect=0x0000700001b097a8, aRenderCallback=mozilla::layers::ImageLayerComposite::(anonymous class) @ 0x0000700001b09508)::$_2) + 399 at LayerManagerComposite.h:560
    frame #5: 0x0000000103f172d9 XUL`mozilla::layers::ImageLayerComposite::RenderLayer(this=0x0000000190faa8a0, aClipRect=0x0000700001b097a8) + 297 at ImageLayerComposite.cpp:97
    frame #6: 0x0000000103f17c7f XUL`non-virtual thunk to mozilla::layers::ImageLayerComposite::RenderLayer(this=0x0000000190faa8a0, aClipRect=0x0000700001b097a8) + 47 at ImageLayerComposite.cpp:82
    frame #7: 0x0000000103f433c3 XUL`void mozilla::layers::RenderLayers<mozilla::layers::ContainerLayerComposite>(aContainer=0x00000001277d07b0, aManager=0x0000000127716dd0, aClipRect=0x0000700001b099f8) + 867 at ContainerLayerComposite.cpp:588
    frame #8: 0x0000000103f2442d XUL`void mozilla::layers::ContainerRender<mozilla::layers::ContainerLayerComposite>(aContainer=0x00000001277d07b0, aManager=0x0000000127716dd0, aClipRect=0x0000700001b09d28) + 1293 at ContainerLayerComposite.cpp:752
    frame #9: 0x0000000103f0e9bf XUL`mozilla::layers::ContainerLayerComposite::RenderLayer(this=0x00000001277d07b0, aClipRect=0x0000700001b09d28) + 47 at ContainerLayerComposite.cpp:826
    frame #10: 0x0000000103f0e9ff XUL`non-virtual thunk to mozilla::layers::ContainerLayerComposite::RenderLayer(this=0x00000001277d07b0, aClipRect=0x0000700001b09d28) + 47 at ContainerLayerComposite.cpp:824
    frame #11: 0x0000000103f433c3 XUL`void mozilla::layers::RenderLayers<mozilla::layers::ContainerLayerComposite>(aContainer=0x0000000118094e70, aManager=0x0000000127716dd0, aClipRect=0x0000700001b09f78) + 867 at ContainerLayerComposite.cpp:588
    frame #12: 0x0000000103f2442d XUL`void mozilla::layers::ContainerRender<mozilla::layers::ContainerLayerComposite>(aContainer=0x0000000118094e70, aManager=0x0000000127716dd0, aClipRect=0x0000700001b0a2c0) + 1293 at ContainerLayerComposite.cpp:752
    frame #13: 0x0000000103f0e9bf XUL`mozilla::layers::ContainerLayerComposite::RenderLayer(this=0x0000000118094e70, aClipRect=0x0000700001b0a2c0) + 47 at ContainerLayerComposite.cpp:826
    frame #14: 0x0000000103f0e9ff XUL`non-virtual thunk to mozilla::layers::ContainerLayerComposite::RenderLayer(this=0x0000000118094e70, aClipRect=0x0000700001b0a2c0) + 47 at ContainerLayerComposite.cpp:824
    frame #15: 0x0000000103f1ad7d XUL`mozilla::layers::LayerManagerComposite::Render(this=0x0000000127716dd0, aInvalidRegion=0x0000700001b0a720) + 2941 at LayerManagerComposite.cpp:939
    frame #16: 0x0000000103f1a067 XUL`mozilla::layers::LayerManagerComposite::UpdateAndRender(this=0x0000000127716dd0) + 1031 at LayerManagerComposite.cpp:492
    frame #17: 0x0000000103f19bbd XUL`mozilla::layers::LayerManagerComposite::EndTransaction(this=0x0000000127716dd0, aTimeStamp=0x0000700001b0a858, aFlags=END_DEFAULT) + 525 at LayerManagerComposite.cpp:414
    frame #18: 0x0000000103f5cf24 XUL`mozilla::layers::CompositorParent::CompositeToTarget(this=0x0000000117acf000, aTarget=0x0000000000000000, aRect=0x0000000000000000) + 996 at CompositorParent.cpp:1278
    frame #19: 0x0000000103f5c654 XUL`mozilla::layers::CompositorVsyncScheduler::ComposeToTarget(this=0x00006080001b1fe0, aTarget=0x0000000000000000, aRect=0x0000000000000000) + 228 at CompositorParent.cpp:660
    frame #20: 0x0000000103f5c0f2 XUL`mozilla::layers::CompositorVsyncScheduler::Composite(this=0x00006080001b1fe0, aVsyncTimestamp=(mValue = 301614537515203)) + 322 at CompositorParent.cpp:531
    frame #21: 0x0000000103f842c7 XUL`void details::CallMethod<0ul, mozilla::layers::CompositorVsyncScheduler, void (mozilla::layers::CompositorVsyncScheduler::*)(mozilla::TimeStamp), mozilla::TimeStamp>((null)=IndexSequence<0> @ 0x0000700001b0a9a8, obj=0x00006080001b1fe0, method=0x0000000103f5bfb0, arg=0x00006080034614f0)(mozilla::TimeStamp), mozilla::Tuple<mozilla::TimeStamp>&) + 167 at task.h:28
    frame #22: 0x0000000103f84215 XUL`void DispatchTupleToMethod<mozilla::layers::CompositorVsyncScheduler, void (mozilla::layers::CompositorVsyncScheduler::*)(mozilla::TimeStamp), mozilla::TimeStamp>(obj=0x00006080001b1fe0, method=0x0000000103f5bfb0, arg=0x00006080034614f0)(mozilla::TimeStamp), mozilla::Tuple<mozilla::TimeStamp>&) + 69 at task.h:46
    frame #23: 0x0000000103f83e5e XUL`RunnableMethod<mozilla::layers::CompositorVsyncScheduler, void (mozilla::layers::CompositorVsyncScheduler::*)(mozilla::TimeStamp), mozilla::Tuple<mozilla::TimeStamp> >::Run(this=0x00006080034614c0) + 78 at task.h:307
    frame #24: 0x0000000102dd2220 XUL`MessageLoop::RunTask(this=0x0000700001b0ad18, task=0x00006080034614c0) + 96 at message_loop.cc:364
    frame #25: 0x0000000102dd278f XUL`MessageLoop::DeferOrRunPendingTask(this=0x0000700001b0ad18, pending_task=0x0000700001b0aae8) + 79 at message_loop.cc:372
    frame #26: 0x0000000102dd29b4 XUL`MessageLoop::DoWork(this=0x0000700001b0ad18) + 292 at message_loop.cc:459
    frame #27: 0x0000000102dd3607 XUL`base::MessagePumpDefault::Run(this=0x000060800125ba80, delegate=0x0000700001b0ad18) + 215 at message_pump_default.cc:34
    frame #28: 0x0000000102dd2105 XUL`MessageLoop::RunInternal(this=0x0000700001b0ad18) + 117 at message_loop.cc:234
    frame #29: 0x0000000102dd2015 XUL`MessageLoop::RunHandler(this=0x0000700001b0ad18) + 21 at message_loop.cc:227
    frame #30: 0x0000000102dd1fbd XUL`MessageLoop::Run(this=0x0000700001b0ad18) + 45 at message_loop.cc:201
    frame #31: 0x0000000102df6ed6 XUL`base::Thread::ThreadMain(this=0x000060800125b990) + 278 at thread.cc:172
    frame #32: 0x0000000102df6fce XUL`ThreadFunc(closure=0x000060800125b990) + 30 at platform_thread_posix.cc:36
    frame #33: 0x00000001000df9f9 libsystem_pthread.dylib`_pthread_body + 131
    frame #34: 0x00000001000df976 libsystem_pthread.dylib`_pthread_start + 168
    frame #35: 0x00000001000dcfbd libsystem_pthread.dylib`thread_start + 13
Attachment #8724516 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8724516 [details]
MozReview Request: Bug 1251910: Fix YUV422 IOSurface. r=mattwoodrow.

https://reviewboard.mozilla.org/r/37051/#review33759

Looks like a rebasing mistake
Priority: -- → P2
Priority: P2 → P1
https://hg.mozilla.org/mozilla-central/rev/0fd6d83f2dc2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.