In rtl left .toolbarbutton-menubutton-button border is missing on hover

RESOLVED FIXED in Thunderbird 47.0

Status

Thunderbird
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 47.0
All
Mac OS X

Thunderbird Tracking Flags

(thunderbird45 fixed, thunderbird46 fixed, thunderbird47 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.29 KB, patch
aleth
: review+
Jorg K [Almost not working on Thunderbird (some bustage-fix only) due to non-renewal of contract]
: approval-comm-aurora+
Jorg K [Almost not working on Thunderbird (some bustage-fix only) due to non-renewal of contract]
: approval-comm-esr45+
Details | Diff | Splinter Review
(Assignee)

Description

2 years ago
Created attachment 8724539 [details] [diff] [review]
rtlBorder.patch

When TB is in rtl direction the left border of .toolbarbutton-menubutton-button is missing when hovering.
(Assignee)

Comment 1

2 years ago
Created attachment 8724540 [details] [diff] [review]
rtlBorder.patch

Simple fix, one -moz-border-end: none; was too much.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8724540 - Flags: review?(aleth)

Updated

2 years ago
Attachment #8724540 - Flags: review?(aleth) → review+
(Assignee)

Comment 2

2 years ago
http://hg.mozilla.org/comm-central/rev/b563a58ac42c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
(Assignee)

Updated

2 years ago
Attachment #8724539 - Attachment is obsolete: true
(Assignee)

Comment 3

2 years ago
Comment on attachment 8724540 [details] [diff] [review]
rtlBorder.patch

[Approval Request Comment]
User impact if declined: not correct toolbarbutton appearance for rtl locales
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8724540 - Flags: approval-comm-beta?
Attachment #8724540 - Flags: approval-comm-aurora?
Attachment #8724540 - Flags: approval-comm-aurora? → approval-comm-aurora+
Aurora (TB 46):
https://hg.mozilla.org/releases/comm-aurora/rev/95d5d062c4e3
status-thunderbird45: --- → affected
status-thunderbird46: --- → fixed
status-thunderbird47: --- → fixed

Comment 5

2 years ago
Comment on attachment 8724540 [details] [diff] [review]
rtlBorder.patch

http://hg.mozilla.org/releases/comm-esr45/rev/70caf9743d6e
Attachment #8724540 - Flags: approval-comm-beta? → approval-comm-beta+

Updated

2 years ago
status-thunderbird45: affected → fixed
Attachment #8724540 - Flags: approval-comm-beta+ → approval-comm-esr45+
You need to log in before you can comment on or make changes to this bug.