1251941 - aria::GetRoleMap should take element

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

a small clean up as we go

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8724550 [details] [diff] [review]
patch

Review of attachment 8724550 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/base/nsCoreUtils.cpp
@@ +241,5 @@
>        }
>      }
>    }
>  
> +  return content && content->IsElement() ? content->AsElement() : nullptr;

nit: for easy readability can we put () around the && condition?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #1)

> > +  return content && content->IsElement() ? content->AsElement() : nullptr;
> 
> nit: for easy readability can we put () around the && condition?

next patch this method will go away, however in general I like "a ? b : c" syntax, when expressions are short

Comment 3

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov from comment #2)
> (In reply to David Bolter [:davidb] from comment #1)
> 
> > > +  return content && content->IsElement() ? content->AsElement() : nullptr;
> > 
> > nit: for easy readability can we put () around the && condition?
> 
> next patch this method will go away, however in general I like "a ? b : c"
> syntax, when expressions are short

but yes, I would

Comment 4

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78d20ae3f50ebe4ce416bbf788a55d7b3050931d
Bug 1251941 - aria::GetRoleMap should take element, r=davidb

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/78d20ae3f50e