Closed Bug 1252015 Opened 4 years ago Closed 4 years ago

ImageDocument::mImageContent should probably be an Element rather than an nsIContent

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: Ms2ger, Assigned: sleroux, Mentored)

Details

(Whiteboard: [lang=c++][good first bug] btpp-backlog)

Attachments

(1 file)

This would allow us to remove the AsElement() calls.

Code: dom/html/ImageDocument.h, dom/html/ImageDocument.cpp
Whiteboard: [lang=c++][good first bug] → [lang=c++][good first bug] btpp-backlog
I wouldn't mind taking this to try out something I learned from the onboarding session. Is the ask to just change the nsCOMPtr to use Element type instead of nsIContent to avoid the AsElement calls?
Yes, that's correct
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Attachment #8726382 - Flags: review?(Ms2ger) → review?(amarchesini)
Comment on attachment 8726382 [details]
MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku

https://reviewboard.mozilla.org/r/37947/#review34711
Attachment #8726382 - Flags: review?(amarchesini) → review+
Thanks!

Sheriff: please update the r= in the commit message, thanks!
Keywords: checkin-needed
has problems to apply:

applying 647c12191f36
patching file dom/html/ImageDocument.cpp
Hunk #1 FAILED at 334
Hunk #3 FAILED at 486
2 out of 4 hunks FAILED -- saving rejects to file dom/html/ImageDocument.cpp.rej
patch failed to apply
abort: fix up the working directory and run hg transplant --continue
Flags: needinfo?(sleroux)
I've gone ahead and transplanted from latest. Do I push it back up to reviewboard?
Flags: needinfo?(sleroux)
I think so, yes/
Comment on attachment 8726382 [details]
MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37947/diff/1-2/
Attachment #8726382 - Attachment description: MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?Ms2ger → MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fd6bbe2b188e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.