Closed
Bug 1252015
Opened 8 years ago
Closed 8 years ago
ImageDocument::mImageContent should probably be an Element rather than an nsIContent
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: sleroux, Mentored)
Details
(Whiteboard: [lang=c++][good first bug] btpp-backlog)
Attachments
(1 file)
This would allow us to remove the AsElement() calls. Code: dom/html/ImageDocument.h, dom/html/ImageDocument.cpp
|
||
Updated•8 years ago
|
Whiteboard: [lang=c++][good first bug] → [lang=c++][good first bug] btpp-backlog
|
Assignee | |
Comment 1•8 years ago
|
||
I wouldn't mind taking this to try out something I learned from the onboarding session. Is the ask to just change the nsCOMPtr to use Element type instead of nsIContent to avoid the AsElement calls?
|
Reporter | |
Comment 2•8 years ago
|
||
Yes, that's correct
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37947/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37947/
Attachment #8726382 -
Flags: review?(Ms2ger)
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8726382 -
Flags: review?(Ms2ger) → review?(amarchesini)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8726382 [details] MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku https://reviewboard.mozilla.org/r/37947/#review34711
Attachment #8726382 -
Flags: review?(amarchesini) → review+
|
|
Reporter | |
Comment 5•8 years ago
|
||
Thanks! Sheriff: please update the r= in the commit message, thanks!
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
has problems to apply: applying 647c12191f36 patching file dom/html/ImageDocument.cpp Hunk #1 FAILED at 334 Hunk #3 FAILED at 486 2 out of 4 hunks FAILED -- saving rejects to file dom/html/ImageDocument.cpp.rej patch failed to apply abort: fix up the working directory and run hg transplant --continue
Flags: needinfo?(sleroux)
|
|
||
Updated•8 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 7•8 years ago
|
||
I've gone ahead and transplanted from latest. Do I push it back up to reviewboard?
Flags: needinfo?(sleroux)
|
|
Reporter | |
Comment 8•8 years ago
|
||
I think so, yes/
|
|
Assignee | |
Comment 9•8 years ago
|
||
Comment on attachment 8726382 [details] MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37947/diff/1-2/
Attachment #8726382 -
Attachment description: MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?Ms2ger → MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku
|
|
Reporter | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd6bbe2b188e
Keywords: checkin-needed
|
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fd6bbe2b188e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•