1252015 - ImageDocument::mImageContent should probably be an Element rather than an nsIContent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This would allow us to remove the AsElement() calls.

Code: dom/html/ImageDocument.h, dom/html/ImageDocument.cpp

Comment 1

[Stephan Leroux [:sleroux]]

I wouldn't mind taking this to try out something I learned from the onboarding session. Is the ask to just change the nsCOMPtr to use Element type instead of nsIContent to avoid the AsElement calls?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yes, that's correct

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku

Review commit: https://reviewboard.mozilla.org/r/37947/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37947/

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8726382 [details]
MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku

https://reviewboard.mozilla.org/r/37947/#review34711

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks!

Sheriff: please update the r= in the commit message, thanks!

Comment 6

[Carsten Book [:Tomcat]]

has problems to apply:

applying 647c12191f36
patching file dom/html/ImageDocument.cpp
Hunk #1 FAILED at 334
Hunk #3 FAILED at 486
2 out of 4 hunks FAILED -- saving rejects to file dom/html/ImageDocument.cpp.rej
patch failed to apply
abort: fix up the working directory and run hg transplant --continue

Comment 7

[Stephan Leroux [:sleroux]]

I've gone ahead and transplanted from latest. Do I push it back up to reviewboard?

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I think so, yes/

Comment 9

[Stephan Leroux [:sleroux]]

Comment on attachment 8726382 [details]
MozReview Request: Bug 1252015 - Changed mImageContent reference to be Element type instead of nsIContent; r?baku

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37947/diff/1-2/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd6bbe2b188e

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fd6bbe2b188e