1252091 - Add/RemoveFeature don't need a JSContext argument

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Now that ModifyBusyCountFromWorker doesn't need one...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add/RemoveFeature don't need a JSContext argument

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8724781 [details] [diff] [review]
Add/RemoveFeature don't need a JSContext argument

Review of attachment 8724781 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/notification/Notification.cpp
@@ +2509,5 @@
>    MOZ_ASSERT(mWorkerPrivate);
>    mWorkerPrivate->AssertIsOnWorkerThread();
>    MOZ_ASSERT(!mFeature);
>    mFeature = MakeUnique<NotificationFeature>(this);
> +  bool added = mWorkerPrivate->AddFeature(mFeature.get());

is the .get() really needed here?  Seems odd.

Comment 3

[Boris Zbarsky [:bzbarsky]]

> is the .get() really needed here?

Yes, because mFeature is UniquePtr.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/954c9e9408fd

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/954c9e9408fd