Add/RemoveFeature don't need a JSContext argument

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

Now that ModifyBusyCountFromWorker doesn't need one...
Comment on attachment 8724781 [details] [diff] [review]
Add/RemoveFeature don't need a JSContext argument

Review of attachment 8724781 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/notification/Notification.cpp
@@ +2509,5 @@
>    MOZ_ASSERT(mWorkerPrivate);
>    mWorkerPrivate->AssertIsOnWorkerThread();
>    MOZ_ASSERT(!mFeature);
>    mFeature = MakeUnique<NotificationFeature>(this);
> +  bool added = mWorkerPrivate->AddFeature(mFeature.get());

is the .get() really needed here?  Seems odd.
Attachment #8724781 - Flags: review?(khuey) → review+
Whiteboard: btpp-active
> is the .get() really needed here?

Yes, because mFeature is UniquePtr.
https://hg.mozilla.org/mozilla-central/rev/954c9e9408fd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.