Closed Bug 1252135 Opened 4 years ago Closed 4 years ago

Convert some tests in dom/events to use pushPrefEnv

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

()

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 3 obsolete files)

Attached patch wip patch (obsolete) — Splinter Review
I was already working on this, but got in some problems like bug 1251905.
This bug is about converting the tests that are easily converted.
Whiteboard: btpp-active

This bug #1252135, Convert some tests in dom/events to use pushPrefEnv, has been reviewed.

An engineer is working on this bug.

You will receive emailed updates on the progress of your bug’s fix from Bugzilla, so make sure that bugzilla-daemon@mozilla.org is not blocked in your spam filters.

Thank you.
Attached patch 1252135_domevents.diff (obsolete) — Splinter Review
Andrew was already working in this area, so asking review on him.
Attachment #8724806 - Attachment is obsolete: true
Attachment #8724915 - Flags: review?(continuation)
Comment on attachment 8724915 [details] [diff] [review]
1252135_domevents.diff

Review of attachment 8724915 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I'm not a peer of this code, but it is all fairly simple test changes so I think it is okay for me to review it.

::: dom/events/test/test_bug409604.html
@@ +217,4 @@
>    }
>  
>    SimpleTest.waitForExplicitFinish();
>    SimpleTest.requestFlakyTimeout("untriaged");

You should be able to remove this requestFlakyTimeout() now.
Attachment #8724915 - Flags: review?(continuation) → review+
Attached patch 1252135_domevents.diff (obsolete) — Splinter Review
Thanks, updated the patch.
Attachment #8724915 - Attachment is obsolete: true
Tryserver was good. Chunk 3 looked orangy, but none of the tests were in that chunk at all, so it is unrelated.
Attachment #8724931 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6422ab4c6fb4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.