Closed Bug 1252195 Opened 4 years ago Closed 4 years ago

remove use of ScopedFreePtr from nsMemoryReporterManager

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(2 files)

part 1 - implement UniqueFreePtr
1008 bytes, patch
Waldo
: review+
Details | Diff | Splinter Review
part 2 - use UniqueFreePtr instead of ScopedFreePtr in nsMemoryReporterManager
1.95 KB, patch
njn
: review+
Details | Diff | Splinter Review 
No description provided.
Just like UniquePtr<T>, except that we're going to delete the allocated
memory with |free()|.
Attachment #8724870 - Flags: review?(jwalden+bmo)
Something derived from UniquePtr is better than something derived from Scoped.
Attachment #8724871 - Flags: review?(n.nethercote)
Attachment #8724871 - Flags: review?(n.nethercote) → review+
Attachment #8724870 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/6d7c88d92388
https://hg.mozilla.org/mozilla-central/rev/e5589c87b44b
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.