1252221 - Don't allow ScriptExecutorRunnable::WorkerRun to leave an exception on the JSContext when global creation fails

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

From my analysis for bug 1072144:

  -- Can leave a pending exception on aCx if GetOrCreateGlobalScope fails.  We
     do return false, but that leaves the exception sitting on aCx, because our
     PostRun does not report exceptions on the JSContext.  XXXbz we should
     probably just steal this exception onto the ErrorResult.  That would mean
     we just report it to console and do NetworkError in terms of error events,
     I think.  That seems alright.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: When GetOrCreateGlobalScope fails while trying to run a ScriptExecutorRunnable::WorkerRun, move the exception to our ErrorResult instead of leaving it on the JSContext

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8724916 [details] [diff] [review]
When GetOrCreateGlobalScope fails while trying to run a ScriptExecutorRunnable::WorkerRun, move the exception to our ErrorResult instead of leaving it on the JSContext

Er, I'm not sure this is the right way to handle this.  Need to think about it a bit more.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: When GetOrCreateGlobalScope fails while trying to run a ScriptExecutorRunnable::WorkerRun, just suppress the exception, because there is no way to report it without a compartment to work with

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7895ac3242bc

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7895ac3242bc