1252239 - Trap NS_ERROR_NOT_AVAILABLE errors from speculativeConnect

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Kris Maglione [:kmag]]

speculativeConnect throws NS_ERROR_NOT_AVAILABLE errors from some of our tests, when certain browser or extension URLs wind up in history, and we accidentally trigger a hover event.

These errors aren't important, but they cause test failures, so we should report them rather than letting them propagate.

Comment 1

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1252239: Trap errors thrown by speculativeConnect. r?ttaubert

Review commit: https://reviewboard.mozilla.org/r/37227/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37227/

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8724918 [details]
MozReview Request: Bug 1252239: Trap errors thrown by speculativeConnect. r?ttaubert

https://reviewboard.mozilla.org/r/37227/#review33775

::: browser/base/content/newtab/sites.js:302
(Diff revision 1)
> +    } catch (e) {
> +      Cu.reportError(e);
> +    }

I think it's ok to just swallow the exception, reporting doesn't really help anyone either as we know it doesn't make sense to speculatively connect to internal sites.

Comment 3

[Kris Maglione [:kmag]]

https://reviewboard.mozilla.org/r/37227/#review33775

> I think it's ok to just swallow the exception, reporting doesn't really help anyone either as we know it doesn't make sense to speculatively connect to internal sites.

Yeah, makes sense.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/e3f38a0b663f2c0aeb5bef33cf7e79868d7d4853
Bug 1252239: Trap errors thrown by speculativeConnect. r=ttaubert

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e3f38a0b663f