Closed Bug 1252239 Opened 5 years ago Closed 5 years ago

Trap NS_ERROR_NOT_AVAILABLE errors from speculativeConnect

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(1 file)

speculativeConnect throws NS_ERROR_NOT_AVAILABLE errors from some of our tests, when certain browser or extension URLs wind up in history, and we accidentally trigger a hover event.

These errors aren't important, but they cause test failures, so we should report them rather than letting them propagate.
Blocks: 1220124
Comment on attachment 8724918 [details]
MozReview Request: Bug 1252239: Trap errors thrown by speculativeConnect. r?ttaubert

https://reviewboard.mozilla.org/r/37227/#review33775

::: browser/base/content/newtab/sites.js:302
(Diff revision 1)
> +    } catch (e) {
> +      Cu.reportError(e);
> +    }

I think it's ok to just swallow the exception, reporting doesn't really help anyone either as we know it doesn't make sense to speculatively connect to internal sites.
Attachment #8724918 - Flags: review?(ttaubert) → review+
https://reviewboard.mozilla.org/r/37227/#review33775

> I think it's ok to just swallow the exception, reporting doesn't really help anyone either as we know it doesn't make sense to speculatively connect to internal sites.

Yeah, makes sense.
https://hg.mozilla.org/mozilla-central/rev/e3f38a0b663f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.