Closed
Bug 1252279
Opened 9 years ago
Closed 9 years ago
Land version 1.1.9 of the Loop system add-on in mozilla-central
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox46 fixed, firefox47 fixed)
People
(Reporter: standard8, Assigned: standard8)
Details
(Whiteboard: [btpp-fix-now])
Attachments
(2 files)
113.07 KB,
patch
|
standard8
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
212.84 KB,
patch
|
standard8
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Since the last version that landed in mozilla-central we have:
- Improved privacy aspects around not sharing context items when sharing is paused.
- FTU tour improvements.
- Minor update to the OpenTok library to stop using moz* prefixes for WebRTC apis by default to avoid warnings, and allow them to start to be obsoleted more.
- Various other fixes (see list of changes in https://github.com/mozilla/loop/blob/v1.1.9/CHANGELOG.md - note some have already landed in central).
Assignee | ||
Comment 1•9 years ago
|
||
Forgot to mention, there's also:
- A few test improvements for mochitests. One to enable a test in e10s mode, the other to hopefully improve stability of one of the tests.
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8724988 -
Flags: review+
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8724989 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → standard8
Rank: 5
Whiteboard: [btpp-fix-now]
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/eea8d5268a984015c89167ce5b84d2844733fda2
Bug 1252279 - Land version 1.1.9 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.
https://hg.mozilla.org/integration/fx-team/rev/b839cf31fa76393f1e2cc7270c88b630ee3e9dc3
Bug 1252279 - Land version 1.1.9 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code.
Comment 5•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eea8d5268a98
https://hg.mozilla.org/mozilla-central/rev/b839cf31fa76
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8724988 [details] [diff] [review]
Land version 1.1.9 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.
Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: This patch is importing string updates from locales
[Describe test coverage new/current, TreeHerder]: N/A
[Risks and why]: Low, string updates
[String/UUID change made/needed]: None (string updates go through the Hello specific flow rather than the Firefox one).
Attachment #8724988 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8724989 [details] [diff] [review]
Land version 1.1.9 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code.
Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: Improves privacy when pausing tab sharing, improves first time user experience, and moves us away from some WebRTC APIs which will be going obsolete soon (see also comment 0)
[Describe test coverage new/current, TreeHerder]: Has unit tests & integration, been in fx-team/central for a few days.
[Risks and why]: Low, small improvements on previously landed version (note: the sdk.js patch is mainly "noise" in comments, there's only a couple of bits that have actually changed).
[String/UUID change made/needed]: None
Attachment #8724989 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
Comment on attachment 8724988 [details] [diff] [review]
Land version 1.1.9 of the Loop system add-on in mozilla-central - locale updates. rs=Standard8 for already reviewed code.
Localization updates for our new system addon process.
Attachment #8724988 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•9 years ago
|
||
Comment on attachment 8724989 [details] [diff] [review]
Land version 1.1.9 of the Loop system add-on in mozilla-central - code updates. rs=Standard8 for already reviewed code.
Rubber stamping this Hello update.
Attachment #8724989 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/ea34d982c699
https://hg.mozilla.org/releases/mozilla-aurora/rev/e1c37c0fc935
status-firefox46:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•